You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "shuwenwei (via GitHub)" <gi...@apache.org> on 2024/01/23 10:37:56 UTC
[PR] Fix read chunk compaction performer null pointer exception [iotdb]
shuwenwei opened a new pull request, #11960:
URL: https://github.com/apache/iotdb/pull/11960
## Description
Fix read chunk compaction performer null pointer exception. If a chunk metadata of one value column in aligned series is null, and other file in compaction does not contain current value column, a null pointer exception may throw.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix read chunk compaction performer null pointer exception [iotdb]
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on code in PR #11960:
URL: https://github.com/apache/iotdb/pull/11960#discussion_r1463067707
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/executor/readchunk/ReadChunkAlignedSeriesCompactionExecutor.java:
##########
@@ -188,6 +195,9 @@ private void compactWithAlignedChunk(
}
pointNum += chunkMetadata.getStatistics().getCount();
ChunkLoader valueChunk = getChunkLoader(reader, (ChunkMetadata) chunkMetadata);
+ if (!measurementSchemaListIndexMap.containsKey(chunkMetadata.getMeasurementUid())) {
+ System.out.println();
+ }
Review Comment:
remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix read chunk compaction performer null pointer exception [iotdb]
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou commented on code in PR #11960:
URL: https://github.com/apache/iotdb/pull/11960#discussion_r1463066578
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/executor/readchunk/ReadChunkAlignedSeriesCompactionExecutor.java:
##########
@@ -92,6 +97,9 @@ public ReadChunkAlignedSeriesCompactionExecutor(
this.writer = writer;
this.targetResource = targetResource;
this.summary = summary;
+ if (device.contains("d_0")) {
+ System.out.println();
+ }
Review Comment:
remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix read chunk compaction performer null pointer exception [iotdb]
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou merged PR #11960:
URL: https://github.com/apache/iotdb/pull/11960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix read chunk compaction performer null pointer exception [iotdb]
Posted by "caozj1011 (via GitHub)" <gi...@apache.org>.
caozj1011 commented on code in PR #11960:
URL: https://github.com/apache/iotdb/pull/11960#discussion_r1463068193
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/executor/readchunk/ReadChunkAlignedSeriesCompactionExecutor.java:
##########
@@ -188,6 +195,9 @@ private void compactWithAlignedChunk(
}
pointNum += chunkMetadata.getStatistics().getCount();
ChunkLoader valueChunk = getChunkLoader(reader, (ChunkMetadata) chunkMetadata);
+ if (!measurementSchemaListIndexMap.containsKey(chunkMetadata.getMeasurementUid())) {
+ System.out.println();
Review Comment:
remove it , too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org