[GitHub] [rocketmq-dashboard] zhangjidi2016 commented on a change in pull request #59: [ISSUE #58] enable the service to support multiple namesrvs

[GitBox <gi...@apache.org>]

zhangjidi2016 commented on a change in pull request #59:
URL: https://github.com/apache/rocketmq-dashboard/pull/59#discussion_r777879140



##########
File path: src/main/java/org/apache/rocketmq/dashboard/config/RMQConfigure.java
##########
@@ -77,6 +81,18 @@ public String getNamesrvAddr() {
         return namesrvAddr;
     }
 
+    public String getNamesrvAddrs() {
+        return namesrvAddrs;
+    }
+
+    public void setNamesrvAddrs(String namesrvAddrs) {
+        this.namesrvAddrs = namesrvAddrs;
+        List<String> nameSrvAddrList = Splitter.on(";").splitToList(this.namesrvAddrs);

Review comment:
       If multiple namesrv services are deployed in a rocketmq cluster, namesrv addresses are connected using ';' by default. So there is a problem If ';' are used to divide multiple rocketmq clusters in here, it cannot distinguish between two namesrv addresses belonging to the same rocketmq cluster or to different rocketmq clusters.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org