You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/09 23:29:09 UTC
[GitHub] [beam] benWize opened a new pull request, #24075: [Github Actions] - Choose RC Commit Workflow
benWize opened a new pull request, #24075:
URL: https://github.com/apache/beam/pull/24075
As part of the [Beam Release Process](https://beam.apache.org/contribute/release-guide/), the following PR includes the workflow to run the [choose_rc_commit.sh](https://github.com/apache/beam/blob/master/release/src/main/scripts/choose_rc_commit.sh) script described in [step 8. Tag a chosen commit for the RC](https://beam.apache.org/contribute/release-guide/#tag-a-chosen-commit-for-the-rc)
Files:
- Choose RC Commit: .github/workflows/choose_rc_commit.yml
- Updated CI.md file
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24075: [Github Actions] - Choose RC Commit Workflow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24075:
URL: https://github.com/apache/beam/pull/24075#issuecomment-1326369246
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #24075: [Github Actions] - Choose RC Commit Workflow
Posted by GitBox <gi...@apache.org>.
damccorm merged PR #24075:
URL: https://github.com/apache/beam/pull/24075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24075: [Github Actions] - Choose RC Commit Workflow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24075:
URL: https://github.com/apache/beam/pull/24075#issuecomment-1333678609
Reminder, please take a look at this pr: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #24075: [Github Actions] - Choose RC Commit Workflow
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #24075:
URL: https://github.com/apache/beam/pull/24075#discussion_r1038405556
##########
.github/workflows/choose_rc_commit.yml:
##########
@@ -0,0 +1,96 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# This workflow will choose a commit to be the basis of a release candidate
+## and push a new tagged commit for that RC.
+
+# To learn more about GitHub Actions in Apache Beam check the CI.md
+
+name: Choose RC Commit
+on:
+ workflow_dispatch:
+ inputs:
+ RELEASE:
+ description: Beam version of current release
+ required: true
+ RC:
+ description: RC version for the release
+ required: true
+ COMMIT:
+ description: Selected commit to create the release
+ required: true
+ PUSH_TAG:
+ description: Push tag (yes/no)
+ required: false
+ default: no
+ OVERWRITE:
+ description: Overwrite RC Tag (yes/no)
+ required: false
+ default: no
+ DEBUG:
+ description: Enable debug flag adding --debug
+ required: false
+ default: ""
Review Comment:
It was unclear from the description that "--debug" and "" are the only valid inputs. Could we change this to a (yes/no) option like the other inputs?
##########
.github/workflows/choose_rc_commit.yml:
##########
@@ -0,0 +1,96 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# This workflow will choose a commit to be the basis of a release candidate
+## and push a new tagged commit for that RC.
+
+# To learn more about GitHub Actions in Apache Beam check the CI.md
+
+name: Choose RC Commit
+on:
+ workflow_dispatch:
+ inputs:
+ RELEASE:
+ description: Beam version of current release
+ required: true
+ RC:
+ description: RC version for the release
+ required: true
+ COMMIT:
+ description: Selected commit to create the release
Review Comment:
For all of these descriptions, could you add an example?
```suggestion
description: Beam version of current release (e.g. 2.XX.0)
required: true
RC:
description: Integer RC version for the release (e.g. 3 for RC3)
required: true
COMMIT:
description: Selected commit to create the release (should be full commit sha)
```
I'm not sure if my suggested descriptions are correct, so please validate. For example, should it be 3 or RC3 for the `RC` input?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24075: [Github Actions] - Choose RC Commit Workflow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24075:
URL: https://github.com/apache/beam/pull/24075#issuecomment-1323570953
Reminder, please take a look at this pr: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24075: [Github Actions] - Choose RC Commit Workflow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24075:
URL: https://github.com/apache/beam/pull/24075#issuecomment-1314431045
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @Abacn for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] benWize commented on pull request #24075: [Github Actions] - Choose RC Commit Workflow
Posted by GitBox <gi...@apache.org>.
benWize commented on PR #24075:
URL: https://github.com/apache/beam/pull/24075#issuecomment-1338267236
Thanks, @damccorm, I applied your suggestions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org