[jira] [Commented] (IVY-1609) Removal of WARN deprecation when not valid

["Jaikiran Pai (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IVY-1609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949137#comment-16949137 ] 

Jaikiran Pai commented on IVY-1609:
-----------------------------------

Hello Greg,

Are you saying that this message gets logged when the `makeSymlinksInMass` attribute isn't being used (irrespective of the value)? The reason we added that message is to prevent users from using that attribute or the setter (irrespective of the value), so that we can just get rid of that setter in a future version. This will give users a chance to be aware that this method/attribute isnt' supposed to be used.

> Removal of WARN deprecation when not valid
> ------------------------------------------
>
>                 Key: IVY-1609
>                 URL: https://issues.apache.org/jira/browse/IVY-1609
>             Project: Ivy
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.5.0-rc1
>            Reporter: Greg Perry
>            Priority: Minor
>              Labels: easyfix
>
> "WARN:  symlinkmass option has been deprecated and will no longer be supported"  gets fed back as a problem message, even when this option is not set.
> I noticed this when trying to get integration to work with embedding ivy.  The program which utilizes ivy checks ResolveReport.getAllProblemMessages()  after a resolve/retrieve is done.  
> It assumes something did not go correctly.
> I don't think its appropriate to send this back in getAllProblemMessages when the  symlinkmass is not set.
> This could be fixed simply by testing if symlinkmass is being set to true in the option
> RetrieveOptions.java line 184
> https://github.com/apache/ant-ivy/blob/master/src/java/org/apache/ivy/core/retrieve/RetrieveOptions.java#L183-L188
>     
> @Deprecated
>     public RetrieveOptions setMakeSymlinksInMass(boolean makeSymlinksInMass) {
>         this.makeSymlinksInMass = makeSymlinksInMass;
>         *if (makeSymlinksInMass) {*
>              Message.warn("symlinkmass option has been deprecated and will no longer be supported");
>          *}*
>         return this;
>     }



--
This message was sent by Atlassian Jira
(v8.3.4#803005)