You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/15 21:58:44 UTC
[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #420: FLINK-29536 - Add WATCH_NAMESPACE env var to operator
morhidi commented on code in PR #420:
URL: https://github.com/apache/flink-kubernetes-operator/pull/420#discussion_r1023287879
##########
flink-kubernetes-webhook/pom.xml:
##########
@@ -96,6 +96,12 @@ under the License.
<version>${okhttp.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
Review Comment:
We're trying to avoid using mockito in the project. We write test classes instead.
##########
pom.xml:
##########
@@ -89,6 +89,8 @@ under the License.
<okhttp.version>4.10.0</okhttp.version>
<snakeyaml.version>1.32</snakeyaml.version>
+
+ <mockito.version>4.8.1</mockito.version>
Review Comment:
Let's remove mockito from the tests.
##########
helm/flink-kubernetes-operator/templates/webhook.yaml:
##########
@@ -85,7 +85,7 @@ metadata:
cert-manager.io/inject-ca-from: {{ .Release.Namespace }}/flink-operator-serving-cert
name: flink-operator-{{ .Release.Namespace }}-webhook-configuration
webhooks:
-- name: flinkoperator.flink.apache.org
+- name: validationwebhook.flink.apache.org
Review Comment:
Why the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org