You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/10/25 12:01:50 UTC
[GitHub] [netbeans] neilcsmith-net opened a new pull request, #4857: Never mark overriding methods as unused, fixes GH4276.
neilcsmith-net opened a new pull request, #4857:
URL: https://github.com/apache/netbeans/pull/4857
Potential fix for #4276 that never marks an overriding method as unused. The superclass definition will still be marked unused if not called. IMO the method can be considered "used" by the superclass, and hints should be over-cautious in preference to over-eager anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4857: Never mark overriding methods as unused, fixes GH4276.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4857:
URL: https://github.com/apache/netbeans/pull/4857#issuecomment-1291683059
Thanks @mbien merging. Strictly speaking this doesn't just affect hints either - unused elements are also highlighted even if the hint is switched off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4857: Never mark overriding methods as unused, fixes GH4276.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4857:
URL: https://github.com/apache/netbeans/pull/4857#issuecomment-1293596455
@mbien it would appear they have to be open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4857: Never mark overriding methods as unused, fixes GH4276.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4857:
URL: https://github.com/apache/netbeans/pull/4857#issuecomment-1293584561
hmm. why does gh not let me link the two issues to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4857: Never mark overriding methods as unused, fixes GH4276.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4857:
URL: https://github.com/apache/netbeans/pull/4857#issuecomment-1293598067
i see. which is weird because I did seem some suggestions of closed issues in the list - so I thought it is probably something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #4857: Never mark overriding methods as unused, fixes GH4276.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged PR #4857:
URL: https://github.com/apache/netbeans/pull/4857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists