[GitHub] [shardingsphere] tuichenchuxin commented on a change in pull request #11895: Refactor single table meta data load

[GitBox <gi...@apache.org>]

tuichenchuxin commented on a change in pull request #11895:
URL: https://github.com/apache/shardingsphere/pull/11895#discussion_r692705016



##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/main/java/org/apache/shardingsphere/sharding/metadata/ShardingTableMetaDataBuilder.java
##########
@@ -173,7 +134,7 @@
     
     private Optional<TableMetaData> loadTableByDataNode(final DataNode dataNode, final DatabaseType databaseType, final Map<String, DataSource> dataSourceMap) {
         try {
-            return TableMetaDataLoader.load(dataSourceMap.get(dataNode.getDataSourceName()), dataNode.getTableName(), databaseType);
+            return DefaultTableMetaDataLoader.load(dataSourceMap.get(dataNode.getDataSourceName()), dataNode.getTableName(), databaseType);

Review comment:
       > @tuichenchuxin Is it possible to use TableMetaDataLoaderEngine to load?
   
   At present, there are still some scenarios where `DefaultTableMetaDataLoader.load` is called separately, which has a lot of impact and has not been modified for the time being. In the future, the logic needs to be unified into the `TableMetaDataLoaderEngine`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org