You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sergio Pena via Review Board <no...@reviews.apache.org> on 2018/06/01 21:15:55 UTC
Re: Review Request 67400: SENTRY-2245: Remove privileges that do not
associate with a role or a user
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67400/#review204203
-----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
Lines 820-822 (patched)
<https://reviews.apache.org/r/67400/#comment286598>
Is this a bug that exists when removing roles as well? If a role is removed from a privilege, then the privilege get staled? or how does the old code remove the stalled privilege?
- Sergio Pena
On May 31, 2018, 2:57 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67400/
> -----------------------------------------------------------
>
> (Updated May 31, 2018, 2:57 p.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda and Sergio Pena.
>
>
> Bugs: sentry-2245
> https://issues.apache.org/jira/browse/sentry-2245
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Delete privilege when it is not associated with user nor role
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 5932335
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java e2d24e5
>
>
> Diff: https://reviews.apache.org/r/67400/diff/1/
>
>
> Testing
> -------
>
> TestSentryStore passed with added case to check number of privileges left
>
>
> Thanks,
>
> Na Li
>
>
Re: Review Request 67400: SENTRY-2245: Remove privileges that do not
associate with a role or a user
Posted by Na Li via Review Board <no...@reviews.apache.org>.
> On June 1, 2018, 9:15 p.m., Sergio Pena wrote:
> > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
> > Lines 820-822 (patched)
> > <https://reviews.apache.org/r/67400/diff/1/?file=2033273#file2033273line820>
> >
> > Is this a bug that exists when removing roles as well? If a role is removed from a privilege, then the privilege get staled? or how does the old code remove the stalled privilege?
when dropping role, dropSentryRoleCore -> removePrivileges -> removeStaledPrivileges. So staled privileges are already removed. there is no such bug in that code.
- Na
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67400/#review204203
-----------------------------------------------------------
On May 31, 2018, 2:57 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67400/
> -----------------------------------------------------------
>
> (Updated May 31, 2018, 2:57 p.m.)
>
>
> Review request for sentry, kalyan kumar kalvagadda and Sergio Pena.
>
>
> Bugs: sentry-2245
> https://issues.apache.org/jira/browse/sentry-2245
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Delete privilege when it is not associated with user nor role
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 5932335
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java e2d24e5
>
>
> Diff: https://reviews.apache.org/r/67400/diff/1/
>
>
> Testing
> -------
>
> TestSentryStore passed with added case to check number of privileges left
>
>
> Thanks,
>
> Na Li
>
>