You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@brooklyn.apache.org by sv...@apache.org on 2017/03/15 13:07:38 UTC
[4/4] brooklyn-server git commit: Closes #590
Closes #590
Use boolean Options correctly in ItemLister
Replaces list-objects' `--catalog-only` and `--ignore-impls` arguments with `--all-classes` and `--include-impls` respectively.
ItemLister defined a few options as booleans whose default was true. Airline treats boolean options as having zero arity and whose existence implies truth. See Airline's [MetadataLoader](https://github.com/airlift/airline/blob/0.7/src/main/java/io/airlift/airline/model/MetadataLoader.java#L156) class.
I've removed the default from all other boolean options to make it clearer that the value is set by Airline.
CloudExplorerLiveTest passes.
Project: http://git-wip-us.apache.org/repos/asf/brooklyn-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-server/commit/5a3a6b69
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-server/tree/5a3a6b69
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-server/diff/5a3a6b69
Branch: refs/heads/master
Commit: 5a3a6b6949d838239b2255b58b6506b6ed5b6346
Parents: bb1da12 116de91
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Authored: Wed Mar 15 15:07:23 2017 +0200
Committer: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Committed: Wed Mar 15 15:07:23 2017 +0200
----------------------------------------------------------------------
.../core/enricher/AbstractEnricher.java | 5 ++-
.../enricher/stock/AbstractAggregator.java | 44 +++++++++++++-------
.../enricher/stock/AbstractTransformer.java | 9 ++--
.../brooklyn/enricher/stock/Aggregator.java | 24 +++++++----
.../apache/brooklyn/enricher/stock/Joiner.java | 33 +++++++++++----
.../brooklyn/enricher/stock/Propagator.java | 16 ++++---
.../brooklyn/enricher/stock/Transformer.java | 9 ++--
.../enricher/stock/reducer/Reducer.java | 22 ++++++----
pom.xml | 2 +-
.../org/apache/brooklyn/cli/AbstractMain.java | 20 ++++-----
.../org/apache/brooklyn/cli/CloudExplorer.java | 8 ++--
.../org/apache/brooklyn/cli/ItemLister.java | 24 ++++++-----
.../main/java/org/apache/brooklyn/cli/Main.java | 30 ++++++-------
.../java/org/apache/brooklyn/cli/CliTest.java | 6 +--
.../brooklyn/cli/CloudExplorerLiveTest.java | 4 +-
15 files changed, 156 insertions(+), 100 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/brooklyn-server/blob/5a3a6b69/pom.xml
----------------------------------------------------------------------