You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2015/12/10 01:02:43 UTC
Review Request 41165: adding a unit test for initiation of suspect
processing when shared/unordered connection is lost
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41165/
-----------------------------------------------------------
Review request for geode, anilkumar gingade, Hitesh Khamesra, Jason Huynh, and Jianxia Chen.
Repository: geode
Description
-------
As part of this work I changed the internal membership listener interfaces to propagate the reason for initiating suspect processing. The test gathers these reasons and asserts that at least one is initiated by TCPConduit.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/admin/internal/DistributedSystemHealthEvaluator.java 534f5592e5a0540c1e63d8f5431525f60aeaecb3
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionAdvisor.java dc76d6b7b8056a526e3640cc7bef771f943257e6
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java 7a9f7c032f9d7188dd9df86c2165bd26ae5e8873
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/MembershipListener.java 78ed51b64eea82833e3b6c381b544934e2956f03
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/ProductUseLog.java 823b3d06119799b9f8fc4d15d62f0add6435676f
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java d12e78df37ebe18c6eb015a8be4d8f19ab9c3c47
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/locks/DLockGrantor.java 92cea62c7dd380781e34c40008bbf134525ff8fb
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/DistributedMembershipListener.java acfd6bad6ea90de0e75c59393a1f6e41ddccd89a
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/Services.java 799f95d32bcc12acd7aff1be150feb6331b7af15
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/SuspectMember.java a03ee92571397b6f849502f6ad92fee2445685a9
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/auth/GMSAuthenticator.java 982942d0d5868526f6fba1664b10031c74bde2fa
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java cc64f9b9b6642b6e1c6afb800f62f051e0ffe4bc
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/Service.java 2f4a728687978a8419ca74b402f6113d8a6772f0
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 3e767ae5b5f4b630db151053d0eb37ddaa174bc6
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java 326491a6261f6d6de25dd17d1ae73eb7e9408eba
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java 4e108be60017c68dd30292499f6c6ab0708f6e3f
gemfire-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/RemoteGfManagerAgent.java eb6246818a6a88524ff4c6c3a0c0376039cd824b
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java 5d263a66522ea481b9eee0cf36f46df40f20c872
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageFlowControl.java a37a39b7454a6f3e5f2546e831cea15d07c4f727
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/PRHARedundancyProvider.java 3e211132e44359d745a6fa60d4eb94863f15b1b9
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java 48f4787f38425c0240143a92903b735b38f39025
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegionHelper.java f4a20daf04ec71d25f93d175e64f11cafdf575b8
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/SearchLoadAndWriteProcessor.java d7caf66aca999a722e498195077789b79fdfdf92
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/TXCommitMessage.java 9648503e5b7b49a9df1cb7f095e33df248ea7af2
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/TXFarSideCMTracker.java c99d8aef433b2d4e06e2f7fb17680418ac0211aa
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java 994990b7c2a867cb3ecea1ee410ad6ca270f1959
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionedRegionRebalanceOp.java 2b21982b0e9c6b104133d5d279eab5c7fbfbe611
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/persistence/BackupManager.java 8f2773625da72426121d72c4f1cde3c3efeaceeb
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/persistence/PersistenceAdvisorImpl.java 21af70023a85be3b501478de3ae29e8172b006cf
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/persistence/PersistentMemberManager.java 87e956b1585433624108cd933decb50479a8640d
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionVector.java 61423d137b6788581001fe1f7bcc858f044bf33d
gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java 30962e7d1a4d2010fe257b91457fa188b80bbb51
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/FederatingManager.java d49589ce710cd4cfa4d0402401f7b8891223590c
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/ManagementMembershipListener.java 561981ccd07d7587ab1c05b08da01912c1eb6247
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/SystemManagementService.java 7ac85b8bac81c207ed5d86168d243a5299ecdc6d
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/beans/MBeanAggregator.java 8c096a4baa32d5a535e61e467d7473a63567a223
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 5b125636db3318acc230c1fb068eb546aad3f38a
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManagerJUnitTest.java 2b59ca5e394ae4cd6a46ea168e1ee1e1526717bd
Diff: https://reviews.apache.org/r/41165/diff/
Testing
-------
Thanks,
Bruce Schuchardt
Re: Review Request 41165: adding a unit test for initiation of suspect
processing when shared/unordered connection is lost
Posted by Jianxia Chen <jc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41165/#review109647
-----------------------------------------------------------
Ship it!
Ship It!
- Jianxia Chen
On Dec. 10, 2015, 12:02 a.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41165/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 12:02 a.m.)
>
>
> Review request for geode, anilkumar gingade, Hitesh Khamesra, Jason Huynh, and Jianxia Chen.
>
>
> Repository: geode
>
>
> Description
> -------
>
> As part of this work I changed the internal membership listener interfaces to propagate the reason for initiating suspect processing. The test gathers these reasons and asserts that at least one is initiated by TCPConduit.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/admin/internal/DistributedSystemHealthEvaluator.java 534f5592e5a0540c1e63d8f5431525f60aeaecb3
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionAdvisor.java dc76d6b7b8056a526e3640cc7bef771f943257e6
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java 7a9f7c032f9d7188dd9df86c2165bd26ae5e8873
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/MembershipListener.java 78ed51b64eea82833e3b6c381b544934e2956f03
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/ProductUseLog.java 823b3d06119799b9f8fc4d15d62f0add6435676f
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/ReplyProcessor21.java d12e78df37ebe18c6eb015a8be4d8f19ab9c3c47
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/locks/DLockGrantor.java 92cea62c7dd380781e34c40008bbf134525ff8fb
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/DistributedMembershipListener.java acfd6bad6ea90de0e75c59393a1f6e41ddccd89a
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/Services.java 799f95d32bcc12acd7aff1be150feb6331b7af15
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/SuspectMember.java a03ee92571397b6f849502f6ad92fee2445685a9
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/auth/GMSAuthenticator.java 982942d0d5868526f6fba1664b10031c74bde2fa
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java cc64f9b9b6642b6e1c6afb800f62f051e0ffe4bc
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/Service.java 2f4a728687978a8419ca74b402f6113d8a6772f0
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java 3e767ae5b5f4b630db151053d0eb37ddaa174bc6
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java 326491a6261f6d6de25dd17d1ae73eb7e9408eba
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java 4e108be60017c68dd30292499f6c6ab0708f6e3f
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/RemoteGfManagerAgent.java eb6246818a6a88524ff4c6c3a0c0376039cd824b
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedRegion.java 5d263a66522ea481b9eee0cf36f46df40f20c872
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageFlowControl.java a37a39b7454a6f3e5f2546e831cea15d07c4f727
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/PRHARedundancyProvider.java 3e211132e44359d745a6fa60d4eb94863f15b1b9
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java 48f4787f38425c0240143a92903b735b38f39025
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegionHelper.java f4a20daf04ec71d25f93d175e64f11cafdf575b8
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/SearchLoadAndWriteProcessor.java d7caf66aca999a722e498195077789b79fdfdf92
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/TXCommitMessage.java 9648503e5b7b49a9df1cb7f095e33df248ea7af2
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/TXFarSideCMTracker.java c99d8aef433b2d4e06e2f7fb17680418ac0211aa
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java 994990b7c2a867cb3ecea1ee410ad6ca270f1959
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionedRegionRebalanceOp.java 2b21982b0e9c6b104133d5d279eab5c7fbfbe611
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/persistence/BackupManager.java 8f2773625da72426121d72c4f1cde3c3efeaceeb
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/persistence/PersistenceAdvisorImpl.java 21af70023a85be3b501478de3ae29e8172b006cf
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/persistence/PersistentMemberManager.java 87e956b1585433624108cd933decb50479a8640d
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionVector.java 61423d137b6788581001fe1f7bcc858f044bf33d
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java 30962e7d1a4d2010fe257b91457fa188b80bbb51
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/FederatingManager.java d49589ce710cd4cfa4d0402401f7b8891223590c
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/ManagementMembershipListener.java 561981ccd07d7587ab1c05b08da01912c1eb6247
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/SystemManagementService.java 7ac85b8bac81c207ed5d86168d243a5299ecdc6d
> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/beans/MBeanAggregator.java 8c096a4baa32d5a535e61e467d7473a63567a223
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java 5b125636db3318acc230c1fb068eb546aad3f38a
> gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManagerJUnitTest.java 2b59ca5e394ae4cd6a46ea168e1ee1e1526717bd
>
> Diff: https://reviews.apache.org/r/41165/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bruce Schuchardt
>
>