You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/14 08:18:57 UTC
[GitHub] [rocketmq] uglycow opened a new pull request #1775: min value for
autoCommitIntervalMillis. #1774
uglycow opened a new pull request #1775: min value for autoCommitIntervalMillis. #1774
URL: https://github.com/apache/rocketmq/pull/1775
## What is the purpose of the change
prevent the client from committing too frequently, we set 1000ms as min value for autoCommitIntervalMillis
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls commented on issue #1775: min value for
autoCommitIntervalMillis. #1774
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1775: min value for autoCommitIntervalMillis. #1774
URL: https://github.com/apache/rocketmq/pull/1775#issuecomment-586216275
[](https://coveralls.io/builds/28733125)
Coverage decreased (-0.07%) to 50.955% when pulling **3320fd5184a6d3e4c5df24e3ea19b676fabd9574 on uglycow:develop** into **d03e46a4cb0be50401a4fcd9132392a6dde43861 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] duhenglucky merged pull request #1775: min value for
autoCommitIntervalMillis. #1774
Posted by GitBox <gi...@apache.org>.
duhenglucky merged pull request #1775: min value for autoCommitIntervalMillis. #1774
URL: https://github.com/apache/rocketmq/pull/1775
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] duhenglucky commented on a change in pull request #1775:
min value for autoCommitIntervalMillis. #1774
Posted by GitBox <gi...@apache.org>.
duhenglucky commented on a change in pull request #1775: min value for autoCommitIntervalMillis. #1774
URL: https://github.com/apache/rocketmq/pull/1775#discussion_r379300367
##########
File path: client/src/main/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumer.java
##########
@@ -315,7 +315,9 @@ public long getAutoCommitIntervalMillis() {
}
public void setAutoCommitIntervalMillis(long autoCommitIntervalMillis) {
- this.autoCommitIntervalMillis = autoCommitIntervalMillis;
+ if (autoCommitIntervalMillis >= 1000) {
Review comment:
It would be better if you can replace this magic number(1000) with a constant variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services