You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/12/23 12:57:45 UTC

[GitHub] [maven-scm] elharo opened a new pull request #113: replace deprecated methods

elharo opened a new pull request #113:
URL: https://github.com/apache/maven-scm/pull/113


   @slachiewicz 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-scm] michael-o commented on a change in pull request #113: replace deprecated methods

Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #113:
URL: https://github.com/apache/maven-scm/pull/113#discussion_r548278697



##########
File path: maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/AbstractScmMojo.java
##########
@@ -445,7 +446,7 @@ public void checkResult( ScmResult result )
             getLog().error( result.getCommandOutput() == null ? "" : result.getCommandOutput() );
 
             throw new MojoExecutionException(
-                "Command failed." + StringUtils.defaultString( result.getProviderMessage() ) );

Review comment:
       The full stop should be replaced by a colon followed by a space.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-scm] elharo merged pull request #113: replace deprecated methods

Posted by GitBox <gi...@apache.org>.
elharo merged pull request #113:
URL: https://github.com/apache/maven-scm/pull/113


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-scm] elharo commented on a change in pull request #113: replace deprecated methods

Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #113:
URL: https://github.com/apache/maven-scm/pull/113#discussion_r548315532



##########
File path: maven-scm-plugin/src/main/java/org/apache/maven/scm/plugin/AbstractScmMojo.java
##########
@@ -445,7 +446,7 @@ public void checkResult( ScmResult result )
             getLog().error( result.getCommandOutput() == null ? "" : result.getCommandOutput() );
 
             throw new MojoExecutionException(
-                "Command failed." + StringUtils.defaultString( result.getProviderMessage() ) );

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org