You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "davidzollo (via GitHub)" <gi...@apache.org> on 2026/07/26 12:58:01 UTC
[PR] [Fix][Connector-V2] Fix Fluss sink writer resource cleanup [seatunnel]
davidzollo opened a new pull request, #11560:
URL: https://github.com/apache/seatunnel/pull/11560
## Purpose
This PR continues and supersedes #11116. It preserves @ThorneANN as the author of the original resource-cleanup commit and rebases the work onto the current `dev` head.
The Fluss sink writer previously had three lifecycle problems:
- partially initialized connections or tables could leak when writer construction failed;
- `close()` stopped after the first failure and could skip closing the connection;
- INFO logging printed the complete Fluss configuration, including user-provided client settings.
## Changes
- close partially initialized resources when construction fails;
- preserve the initialization failure as the primary exception and attach cleanup failures as suppressed exceptions;
- always attempt to close both the table and connection, preserving failures in close order;
- pass the stable Fluss connector identity to `CommonError.closeFailed`;
- log only `bootstrap.servers` instead of the full client configuration;
- add focused tests for successful shutdown, constructor-failure cleanup, and dual close-failure aggregation.
## Compatibility
No configuration option, default value, public API, serialization format, or connector registration changes. The change only strengthens failure cleanup, error reporting, and log redaction.
## Verification
- `./mvnw -f seatunnel-connectors-v2/connector-fluss/pom.xml spotless:apply -nsu -Dmaven.gitcommitid.skip=true` — passed
- `./mvnw -f seatunnel-connectors-v2/connector-fluss/pom.xml spotless:check -nsu -Dmaven.gitcommitid.skip=true` — passed
- Local compile, unit tests, E2E, Docker, and service startup were not run under the SeaTunnel local-verification policy; the current PR head GitHub CI is the functional verification gate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2] Fix Fluss sink writer resource cleanup [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11560:
URL: https://github.com/apache/seatunnel/pull/11560#issuecomment-5083607173
This follow-up PR is no longer needed because the completed fix has been consolidated back into the original contributor PR #11116. Keeping #11116 as the canonical PR preserves the original contribution history and gives the author the credit and continuity they deserve. Thank you to everyone who helped us get the Fluss cleanup fix into a merge-ready shape.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Connector-V2] Fix Fluss sink writer resource cleanup [seatunnel]
Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo closed pull request #11560: [Fix][Connector-V2] Fix Fluss sink writer resource cleanup
URL: https://github.com/apache/seatunnel/pull/11560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org