You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/01/15 21:25:22 UTC
[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request
#2870: [GOBBLIN-1027] add metrics for users running gaas jobs
sv2000 commented on a change in pull request #2870: [GOBBLIN-1027] add metrics for users running gaas jobs
URL: https://github.com/apache/incubator-gobblin/pull/2870#discussion_r367114498
##########
File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -788,6 +794,33 @@ private ContextAwareCounter getRunningJobsCounter(DagNode<JobExecutionPlan> dagN
dagNode.getValue().getSpecExecutor().getUri().toString()));
}
+ private List<ContextAwareCounter> getRunningJobsCounterForUser(DagNode<JobExecutionPlan> dagNode) {
+ Properties props = dagNode.getValue().getJobSpec().getConfigAsProperties();
Review comment:
Why not getJobSpec.getConfig() and work with Config object instead of Properties?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services