[GitHub] [iceberg] danielcweeks commented on a diff in pull request #7688: Add adaptive split size

["danielcweeks (via GitHub)" <gi...@apache.org>]

danielcweeks commented on code in PR #7688:
URL: https://github.com/apache/iceberg/pull/7688#discussion_r1206086281


##########
core/src/main/java/org/apache/iceberg/BaseScan.java:
##########
@@ -187,7 +193,10 @@ public long targetSplitSize() {
     long tableValue =
         PropertyUtil.propertyAsLong(
             table().properties(), TableProperties.SPLIT_SIZE, TableProperties.SPLIT_SIZE_DEFAULT);
-    return PropertyUtil.propertyAsLong(context.options(), TableProperties.SPLIT_SIZE, tableValue);
+
+    long splitSize = adaptiveSplitSize(tableValue).orElse(tableValue);

Review Comment:
   No, because the table size is typically going to be configured as the default.  Small tables won't align well with that.  Even if it is set to a smaller value, it may collapse too much.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org