You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whimsical.apache.org by Brett Porter <br...@apache.org> on 2016/01/20 14:00:41 UTC
Problems with action items
I noticed that I can't currently update the status of an action item on
Whimsy. It reports an error in the console that a is undefined referencing
a.ownerDocument.
I hoped to look into it tomorrow - but does anyone have any pointers (or a
quick fix)?
Cheers,
Brett
Re: Problems with action items
Posted by Sam Ruby <ru...@intertwingly.net>.
On Wed, Jan 20, 2016 at 9:07 AM, Brett Porter <br...@apache.org> wrote:
> Can confirm that works locally. Do all 3 such references need to be updated?
Better yet, switch to ids:
https://github.com/rubys/whimsy-agenda/commit/7e7f569a2df60effca3147f13f5dd46a10f3c56f
- Sam Ruby
P.S. Pleased to see that you have this up and running! After this
board meetings, I'll merge this into apache/whimsy and deploy it on
whimsy-test.
> On 21 January 2016 at 00:46, Sam Ruby <ru...@intertwingly.net> wrote:
>
>> On Wed, Jan 20, 2016 at 8:00 AM, Brett Porter <br...@apache.org> wrote:
>> > I noticed that I can't currently update the status of an action item on
>> > Whimsy. It reports an error in the console that a is undefined
>> referencing
>> > a.ownerDocument.
>> >
>> > I hoped to look into it tomorrow - but does anyone have any pointers (or
>> a
>> > quick fix)?
>>
>> I can provide you a "quick fix" but I want to understand it more
>> before proceeding. The quick fix is as follows:
>>
>> ---
>>
>> $ git diff
>> diff --git a/views/pages/action-items.js.rb
>> b/views/pages/action-items.js.rb
>> index 600319d..4a3c8d5 100644
>> --- a/views/pages/action-items.js.rb
>> +++ b/views/pages/action-items.js.rb
>> @@ -201,7 +201,7 @@ class ActionItems < React
>> action.baseline = action.status
>>
>> # show dialog
>> - jQuery(~updateStatusForm).modal(:show)
>> + jQuery(~updateStatusForm.getDOMNode()).modal(:show)
>>
>> # update state
>> self.setState(action)
>>
>> ---
>>
>> Get DOMNode is supposed to have gone away in React.js 0.14. Puzzling.
>>
>> > Cheers,
>> > Brett
>>
>> - Sam Ruby
>>
Re: Problems with action items
Posted by Brett Porter <br...@apache.org>.
Can confirm that works locally. Do all 3 such references need to be updated?
On 21 January 2016 at 00:46, Sam Ruby <ru...@intertwingly.net> wrote:
> On Wed, Jan 20, 2016 at 8:00 AM, Brett Porter <br...@apache.org> wrote:
> > I noticed that I can't currently update the status of an action item on
> > Whimsy. It reports an error in the console that a is undefined
> referencing
> > a.ownerDocument.
> >
> > I hoped to look into it tomorrow - but does anyone have any pointers (or
> a
> > quick fix)?
>
> I can provide you a "quick fix" but I want to understand it more
> before proceeding. The quick fix is as follows:
>
> ---
>
> $ git diff
> diff --git a/views/pages/action-items.js.rb
> b/views/pages/action-items.js.rb
> index 600319d..4a3c8d5 100644
> --- a/views/pages/action-items.js.rb
> +++ b/views/pages/action-items.js.rb
> @@ -201,7 +201,7 @@ class ActionItems < React
> action.baseline = action.status
>
> # show dialog
> - jQuery(~updateStatusForm).modal(:show)
> + jQuery(~updateStatusForm.getDOMNode()).modal(:show)
>
> # update state
> self.setState(action)
>
> ---
>
> Get DOMNode is supposed to have gone away in React.js 0.14. Puzzling.
>
> > Cheers,
> > Brett
>
> - Sam Ruby
>
Re: Problems with action items
Posted by Sam Ruby <ru...@intertwingly.net>.
On Wed, Jan 20, 2016 at 8:00 AM, Brett Porter <br...@apache.org> wrote:
> I noticed that I can't currently update the status of an action item on
> Whimsy. It reports an error in the console that a is undefined referencing
> a.ownerDocument.
>
> I hoped to look into it tomorrow - but does anyone have any pointers (or a
> quick fix)?
I can provide you a "quick fix" but I want to understand it more
before proceeding. The quick fix is as follows:
---
$ git diff
diff --git a/views/pages/action-items.js.rb b/views/pages/action-items.js.rb
index 600319d..4a3c8d5 100644
--- a/views/pages/action-items.js.rb
+++ b/views/pages/action-items.js.rb
@@ -201,7 +201,7 @@ class ActionItems < React
action.baseline = action.status
# show dialog
- jQuery(~updateStatusForm).modal(:show)
+ jQuery(~updateStatusForm.getDOMNode()).modal(:show)
# update state
self.setState(action)
---
Get DOMNode is supposed to have gone away in React.js 0.14. Puzzling.
> Cheers,
> Brett
- Sam Ruby