You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by jp...@apache.org on 2019/07/25 17:59:47 UTC

[lucene-solr] branch master updated: LUCENE-8931: Remove Custom ScoreDoc Equality Method (#806)

This is an automated email from the ASF dual-hosted git repository.

jpountz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/master by this push:
     new 29f941b  LUCENE-8931: Remove Custom ScoreDoc Equality Method (#806)
29f941b is described below

commit 29f941baa2e46738446b99aed1d1b3288b49f45c
Author: Atri Sharma <at...@gmail.com>
AuthorDate: Thu Jul 25 23:29:40 2019 +0530

    LUCENE-8931: Remove Custom ScoreDoc Equality Method (#806)
---
 .../lucene/search/TestTopFieldCollectorEarlyTermination.java | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/lucene/core/src/test/org/apache/lucene/search/TestTopFieldCollectorEarlyTermination.java b/lucene/core/src/test/org/apache/lucene/search/TestTopFieldCollectorEarlyTermination.java
index a92a100..da75eba 100644
--- a/lucene/core/src/test/org/apache/lucene/search/TestTopFieldCollectorEarlyTermination.java
+++ b/lucene/core/src/test/org/apache/lucene/search/TestTopFieldCollectorEarlyTermination.java
@@ -160,7 +160,7 @@ public class TestTopFieldCollectorEarlyTermination extends LuceneTestCase {
         } else {
           assertEquals(td2.totalHits.value, td1.totalHits.value);
         }
-        assertTopDocsEquals(td1.scoreDocs, td2.scoreDocs);
+        CheckHits.checkEqual(query, td1.scoreDocs, td2.scoreDocs);
       }
       closeIndex();
     }
@@ -233,14 +233,4 @@ public class TestTopFieldCollectorEarlyTermination extends LuceneTestCase {
         new Sort(new SortField("a", SortField.Type.LONG), new SortField("b", SortField.Type.STRING)),
         new Sort(new SortField("c", SortField.Type.LONG), new SortField("b", SortField.Type.STRING))));
   }
-
-  private static void assertTopDocsEquals(ScoreDoc[] scoreDocs1, ScoreDoc[] scoreDocs2) {
-    assertEquals(scoreDocs1.length, scoreDocs2.length);
-    for (int i = 0; i < scoreDocs1.length; ++i) {
-      final ScoreDoc scoreDoc1 = scoreDocs1[i];
-      final ScoreDoc scoreDoc2 = scoreDocs2[i];
-      assertEquals(scoreDoc1.doc, scoreDoc2.doc);
-      assertEquals(scoreDoc1.score, scoreDoc2.score, 0f);
-    }
-  }
 }