You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/05/10 09:25:00 UTC
Review Request 59136: Added functions to add/remove resource
providers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59136/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Jie Yu.
Repository: mesos
Description
-------
Added functions to add/remove resource providers.
Diffs
-----
src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad
Diff: https://reviews.apache.org/r/59136/diff/1/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 59136: Added functions to add/remove resource
providers.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59136/#review176558
-----------------------------------------------------------
src/master/master.hpp
Lines 1857 (patched)
<https://reviews.apache.org/r/59136/#comment249944>
s/LocalResourceProviders/ResourceProviders/
- Jie Yu
On May 31, 2017, 12:44 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59136/
> -----------------------------------------------------------
>
> (Updated May 31, 2017, 12:44 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-7592
> https://issues.apache.org/jira/browse/MESOS-7592
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
> src/master/master.cpp 14007e08f509446005423e223d5dd76a70744e27
>
>
> Diff: https://reviews.apache.org/r/59136/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 59136: Added functions to add/remove resource
providers.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59136/
-----------------------------------------------------------
(Updated May 31, 2017, 2:44 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Bugs: MESOS-7592
https://issues.apache.org/jira/browse/MESOS-7592
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
src/master/master.cpp 14007e08f509446005423e223d5dd76a70744e27
Diff: https://reviews.apache.org/r/59136/diff/3/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 59136: Added functions to add/remove resource
providers.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59136/
-----------------------------------------------------------
(Updated May 31, 2017, 12:01 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Rebased to use `LocalResourceProvider`.
Repository: mesos
Description (updated)
-------
See summary.
Diffs (updated)
-----
src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
src/master/master.cpp 14007e08f509446005423e223d5dd76a70744e27
Diff: https://reviews.apache.org/r/59136/diff/3/
Changes: https://reviews.apache.org/r/59136/diff/2-3/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 59136: Added functions to add/remove resource
providers.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59136/
-----------------------------------------------------------
(Updated May 10, 2017, 4:12 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Remove unnecessary `link` call.
Repository: mesos
Description
-------
Added functions to add/remove resource providers.
Diffs (updated)
-----
src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad
Diff: https://reviews.apache.org/r/59136/diff/2/
Changes: https://reviews.apache.org/r/59136/diff/1-2/
Testing
-------
make check
Thanks,
Jan Schlicht