[GitHub] sdedic commented on a change in pull request #715: WIP: Download nbjavac when turning on support for Java

[GitBox <gi...@apache.org>]

sdedic commented on a change in pull request #715: WIP: Download nbjavac when turning on support for Java
URL: https://github.com/apache/incubator-netbeans/pull/715#discussion_r215580949
 
 

 ##########
 File path: autoupdate.services/src/org/netbeans/api/autoupdate/InstallSupport.java
 ##########
 @@ -120,7 +120,7 @@ public Installer doValidate(Validator validator, ProgressHandle progress/*or nul
      * @see #doValidate
      */
     public Restarter doInstall(Installer installer ,ProgressHandle progress/*or null*/) throws OperationException {
-        Boolean restart = impl.doInstall (installer, progress, false);
 
 Review comment:
   Why force install ? This will, I think, disable restart for all cases especially when some module indicates the platform needs to be restarted (`needsrestart` in autoupdate xml catalog) ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists