You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/13 22:14:28 UTC
[GitHub] [airflow] ashb commented on a change in pull request #12352: Manage Flask AppBuilder Tables using Alembic Migrations
ashb commented on a change in pull request #12352:
URL: https://github.com/apache/airflow/pull/12352#discussion_r523260805
##########
File path: airflow/migrations/versions/92c57b58940d_add_fab_tables.py
##########
@@ -0,0 +1,173 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Create FAB Tables & Increase length of ab_view_menu.name column
Review comment:
This should be two migrations please
##########
File path: airflow/migrations/versions/92c57b58940d_add_fab_tables.py
##########
@@ -0,0 +1,173 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Create FAB Tables & Increase length of ab_view_menu.name column
+
+Revision ID: 92c57b58940d
+Revises: 45ba3f1493b9
+Create Date: 2020-11-13 19:27:10.161814
+
+"""
+
+import sqlalchemy as sa
+from alembic import op
+from sqlalchemy.engine.reflection import Inspector
+
+# revision identifiers, used by Alembic.
+revision = '92c57b58940d'
+down_revision = '45ba3f1493b9'
+branch_labels = None
+depends_on = None
+
+
+def upgrade():
+ """Create FAB Tables"""
+ conn = op.get_bind()
+ inspector = Inspector.from_engine(conn)
+ tables = inspector.get_table_names()
+ if "ab_permission" not in tables:
+ op.create_table(
+ 'ab_permission',
+ sa.Column('id', sa.INTEGER(), nullable=False, primary_key=True),
+ sa.Column('name', sa.String(length=100), nullable=False),
+ sa.PrimaryKeyConstraint('id'),
+ sa.UniqueConstraint('name'),
+ )
+
+ if "ab_view_menu" not in tables:
+ op.create_table(
+ 'ab_view_menu',
+ sa.Column('id', sa.INTEGER(), nullable=False, primary_key=True),
+ sa.Column('name', sa.String(length=100), nullable=False),
+ sa.PrimaryKeyConstraint('id'),
+ sa.UniqueConstraint('name'),
+ )
+
+ if "ab_role" not in tables:
+ op.create_table(
+ 'ab_role',
+ sa.Column('id', sa.INTEGER(), nullable=False, primary_key=True),
+ sa.Column('name', sa.String(length=64), nullable=False),
+ sa.PrimaryKeyConstraint('id'),
+ sa.UniqueConstraint('name'),
+ )
+
+ if "ab_permission_view" not in tables:
+ op.create_table(
+ 'ab_permission_view',
+ sa.Column('id', sa.INTEGER(), nullable=False, primary_key=True),
+ sa.Column('permission_id', sa.INTEGER(), nullable=True),
+ sa.Column('view_menu_id', sa.INTEGER(), nullable=True),
+ sa.ForeignKeyConstraint(['permission_id'], ['ab_permission.id']),
+ sa.ForeignKeyConstraint(['view_menu_id'], ['ab_view_menu.id']),
+ sa.PrimaryKeyConstraint('id'),
+ sa.UniqueConstraint('permission_id', 'view_menu_id'),
+ )
+
+ if "ab_permission_view_role" not in tables:
+ op.create_table(
+ 'ab_permission_view_role',
+ sa.Column('id', sa.INTEGER(), nullable=False, primary_key=True),
+ sa.Column('permission_view_id', sa.INTEGER(), nullable=True),
+ sa.Column('role_id', sa.INTEGER(), nullable=True),
+ sa.ForeignKeyConstraint(['permission_view_id'], ['ab_permission_view.id']),
+ sa.ForeignKeyConstraint(['role_id'], ['ab_role.id']),
+ sa.PrimaryKeyConstraint('id'),
+ sa.UniqueConstraint("permission_view_id", "role_id"),
+ )
+
+ if "ab_user" not in tables:
+ op.create_table(
+ 'ab_user',
+ sa.Column('id', sa.INTEGER(), nullable=False, primary_key=True),
+ sa.Column('first_name', sa.String(length=64), nullable=False),
+ sa.Column('last_name', sa.String(length=64), nullable=False),
+ sa.Column('username', sa.String(length=64), nullable=False),
+ sa.Column('password', sa.String(length=256), nullable=True),
+ sa.Column('active', sa.BOOLEAN(), nullable=True),
+ sa.Column('email', sa.String(length=64), nullable=False),
+ sa.Column('last_login', sa.DATETIME(), nullable=True),
+ sa.Column('login_count', sa.INTEGER(), nullable=True),
+ sa.Column('fail_login_count', sa.INTEGER(), nullable=True),
+ sa.Column('created_on', sa.DATETIME(), nullable=True),
+ sa.Column('changed_on', sa.DATETIME(), nullable=True),
+ sa.Column('created_by_fk', sa.INTEGER(), nullable=True),
+ sa.Column('changed_by_fk', sa.INTEGER(), nullable=True),
+ sa.ForeignKeyConstraint(['changed_by_fk'], ['ab_user.id']),
+ sa.ForeignKeyConstraint(['created_by_fk'], ['ab_user.id']),
+ sa.PrimaryKeyConstraint('id'),
+ sa.UniqueConstraint('email'),
+ sa.UniqueConstraint('username'),
+ )
+
+ if "ab_user_role" not in tables:
+ op.create_table(
+ 'ab_user_role',
+ sa.Column('id', sa.INTEGER(), nullable=False, primary_key=True),
+ sa.Column('user_id', sa.INTEGER(), nullable=True),
+ sa.Column('role_id', sa.INTEGER(), nullable=True),
+ sa.ForeignKeyConstraint(
+ ['role_id'],
+ ['ab_role.id'],
+ ),
+ sa.ForeignKeyConstraint(
+ ['user_id'],
+ ['ab_user.id'],
+ ),
+ sa.PrimaryKeyConstraint('id'),
+ sa.UniqueConstraint('user_id', 'role_id'),
+ )
+
+ if "ab_register_user" not in tables:
+ op.create_table(
+ 'ab_register_user',
+ sa.Column('id', sa.INTEGER(), nullable=False, primary_key=True),
+ sa.Column('first_name', sa.String(length=64), nullable=False),
+ sa.Column('last_name', sa.String(length=64), nullable=False),
+ sa.Column('username', sa.String(length=64), nullable=False),
+ sa.Column('password', sa.String(length=256), nullable=True),
+ sa.Column('email', sa.String(length=64), nullable=False),
+ sa.Column('registration_date', sa.DATETIME(), nullable=True),
+ sa.Column('registration_hash', sa.String(length=256), nullable=True),
+ sa.PrimaryKeyConstraint('id'),
+ sa.UniqueConstraint('username'),
+ )
+
+ # Increase length of ab_view_menu.name column
+ with op.batch_alter_table('ab_view_menu') as batch_op:
+ batch_op.alter_column('name', type_=sa.String(length=250), nullable=False)
+
+
+def downgrade():
+ """Drop FAB Tables"""
+ conn = op.get_bind()
+ inspector = Inspector.from_engine(conn)
+ fab_tables = [table for table in inspector.get_table_names() if table.startswith("ab_")]
Review comment:
I'd feel more comfortable explicitly listing the tables we add above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org