[GitHub] [incubator-superset] nytai commented on a change in pull request #10526: feat: SIP-34 card/grid views for dashboards and charts

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #10526:
URL: https://github.com/apache/incubator-superset/pull/10526#discussion_r467217123



##########
File path: superset-frontend/src/components/FaveStar.tsx
##########
@@ -59,7 +60,7 @@ export default class FaveStar extends React.PureComponent<FaveStarProps> {
                   ? 'favorite-selected'
                   : 'favorite-unselected'
               }
-              viewBox="0 0 16 15"
+              viewBox={this.props.viewBox || '0 0 16 16'}

Review comment:
       ah good catch, I didn't notice that. All the other icons have a size of 24 and a viewbox of `0 0 24 24`, so we should probably standardize around that and override where necessary. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org