You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Brock Noland <br...@cloudera.com> on 2014/03/06 15:51:17 UTC
Review Request 18845: SENTRY-130 - Integrate sentry script
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18845/
-----------------------------------------------------------
Review request for sentry, Prasad Mujumdar and Shreepadma Venugopalan.
Bugs: SENTRY-130
https://issues.apache.org/jira/browse/SENTRY-130
Repository: sentry
Description
-------
Integrates the the db policy service into bin/sentr
Diffs
-----
bin/config-tool.sh b286421
bin/sentry 6c40f68
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java e59b747
sentry-core/sentry-core-common/pom.xml d50963e
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/Command.java PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryUserException.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/Command.java 528f7d7
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/SentryMain.java 3cb5e54
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/SentryUserException.java 2b24703
Diff: https://reviews.apache.org/r/18845/diff/
Testing
-------
I am able to start both commands.
Thanks,
Brock Noland
Re: Review Request 18845: SENTRY-130 - Integrate sentry script
Posted by Brock Noland <br...@cloudera.com>.
> On March 7, 2014, 1:47 a.m., Shreepadma Venugopalan wrote:
> > bin/sentry, line 67
> > <https://reviews.apache.org/r/18845/diff/1/?file=512340#file512340line67>
> >
> > What if we have only solr + sentry? Do we still require HIVE_HOME be defined?
The script as written today requires hive to be installed. This was done in SENTRY-3. If we want to change that I think it should be in a follow-on jira. However, I don't see this is as a huge concern because all of the mgmt tools and documentation I know of installs all packages on all nodes so hive will be installed even if it's not used.
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18845/#review36471
-----------------------------------------------------------
On March 6, 2014, 2:51 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18845/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 2:51 p.m.)
>
>
> Review request for sentry, Prasad Mujumdar and Shreepadma Venugopalan.
>
>
> Bugs: SENTRY-130
> https://issues.apache.org/jira/browse/SENTRY-130
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Integrates the the db policy service into bin/sentr
>
>
> Diffs
> -----
>
> bin/config-tool.sh b286421
> bin/sentry 6c40f68
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java e59b747
> sentry-core/sentry-core-common/pom.xml d50963e
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/Command.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryUserException.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/Command.java 528f7d7
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/SentryMain.java 3cb5e54
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/SentryUserException.java 2b24703
>
> Diff: https://reviews.apache.org/r/18845/diff/
>
>
> Testing
> -------
>
> I am able to start both commands.
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request 18845: SENTRY-130 - Integrate sentry script
Posted by Brock Noland <br...@cloudera.com>.
> On March 7, 2014, 1:47 a.m., Shreepadma Venugopalan wrote:
> > bin/sentry, line 67
> > <https://reviews.apache.org/r/18845/diff/1/?file=512340#file512340line67>
> >
> > What if we have only solr + sentry? Do we still require HIVE_HOME be defined?
>
> Brock Noland wrote:
> The script as written today requires hive to be installed. This was done in SENTRY-3. If we want to change that I think it should be in a follow-on jira. However, I don't see this is as a huge concern because all of the mgmt tools and documentation I know of installs all packages on all nodes so hive will be installed even if it's not used.
"The script as written today requires hive to be installed."
The addition above just gives users a better error message if that is not true.
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18845/#review36471
-----------------------------------------------------------
On March 6, 2014, 2:51 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18845/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 2:51 p.m.)
>
>
> Review request for sentry, Prasad Mujumdar and Shreepadma Venugopalan.
>
>
> Bugs: SENTRY-130
> https://issues.apache.org/jira/browse/SENTRY-130
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Integrates the the db policy service into bin/sentr
>
>
> Diffs
> -----
>
> bin/config-tool.sh b286421
> bin/sentry 6c40f68
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java e59b747
> sentry-core/sentry-core-common/pom.xml d50963e
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/Command.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryUserException.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/Command.java 528f7d7
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/SentryMain.java 3cb5e54
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/SentryUserException.java 2b24703
>
> Diff: https://reviews.apache.org/r/18845/diff/
>
>
> Testing
> -------
>
> I am able to start both commands.
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request 18845: SENTRY-130 - Integrate sentry script
Posted by Shreepadma Venugopalan <sh...@cloudera.com>.
> On March 7, 2014, 1:47 a.m., Shreepadma Venugopalan wrote:
> > bin/sentry, line 67
> > <https://reviews.apache.org/r/18845/diff/1/?file=512340#file512340line67>
> >
> > What if we have only solr + sentry? Do we still require HIVE_HOME be defined?
>
> Brock Noland wrote:
> The script as written today requires hive to be installed. This was done in SENTRY-3. If we want to change that I think it should be in a follow-on jira. However, I don't see this is as a huge concern because all of the mgmt tools and documentation I know of installs all packages on all nodes so hive will be installed even if it's not used.
>
> Brock Noland wrote:
> "The script as written today requires hive to be installed."
>
> The addition above just gives users a better error message if that is not true.
We can address in a follow-on if needed. LGTM.
- Shreepadma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18845/#review36471
-----------------------------------------------------------
On March 6, 2014, 2:51 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18845/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 2:51 p.m.)
>
>
> Review request for sentry, Prasad Mujumdar and Shreepadma Venugopalan.
>
>
> Bugs: SENTRY-130
> https://issues.apache.org/jira/browse/SENTRY-130
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Integrates the the db policy service into bin/sentr
>
>
> Diffs
> -----
>
> bin/config-tool.sh b286421
> bin/sentry 6c40f68
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java e59b747
> sentry-core/sentry-core-common/pom.xml d50963e
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/Command.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryUserException.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/Command.java 528f7d7
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/SentryMain.java 3cb5e54
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/SentryUserException.java 2b24703
>
> Diff: https://reviews.apache.org/r/18845/diff/
>
>
> Testing
> -------
>
> I am able to start both commands.
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request 18845: SENTRY-130 - Integrate sentry script
Posted by Shreepadma Venugopalan <sh...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18845/#review36471
-----------------------------------------------------------
bin/sentry
<https://reviews.apache.org/r/18845/#comment67456>
What if we have only solr + sentry? Do we still require HIVE_HOME be defined?
- Shreepadma Venugopalan
On March 6, 2014, 2:51 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18845/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 2:51 p.m.)
>
>
> Review request for sentry, Prasad Mujumdar and Shreepadma Venugopalan.
>
>
> Bugs: SENTRY-130
> https://issues.apache.org/jira/browse/SENTRY-130
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Integrates the the db policy service into bin/sentr
>
>
> Diffs
> -----
>
> bin/config-tool.sh b286421
> bin/sentry 6c40f68
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java e59b747
> sentry-core/sentry-core-common/pom.xml d50963e
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/Command.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryUserException.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/Command.java 528f7d7
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/SentryMain.java 3cb5e54
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/SentryUserException.java 2b24703
>
> Diff: https://reviews.apache.org/r/18845/diff/
>
>
> Testing
> -------
>
> I am able to start both commands.
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request 18845: SENTRY-130 - Integrate sentry script
Posted by Shreepadma Venugopalan <sh...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18845/#review36567
-----------------------------------------------------------
Ship it!
Ship It!
- Shreepadma Venugopalan
On March 6, 2014, 2:51 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18845/
> -----------------------------------------------------------
>
> (Updated March 6, 2014, 2:51 p.m.)
>
>
> Review request for sentry, Prasad Mujumdar and Shreepadma Venugopalan.
>
>
> Bugs: SENTRY-130
> https://issues.apache.org/jira/browse/SENTRY-130
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Integrates the the db policy service into bin/sentr
>
>
> Diffs
> -----
>
> bin/config-tool.sh b286421
> bin/sentry 6c40f68
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java e59b747
> sentry-core/sentry-core-common/pom.xml d50963e
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/Command.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryUserException.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/Command.java 528f7d7
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/SentryMain.java 3cb5e54
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/SentryUserException.java 2b24703
>
> Diff: https://reviews.apache.org/r/18845/diff/
>
>
> Testing
> -------
>
> I am able to start both commands.
>
>
> Thanks,
>
> Brock Noland
>
>