[GitHub] [pulsar] Shawyeok opened a new issue, #19112: PIP-235: Add metric for subscription back size

[GitBox <gi...@apache.org>]

Shawyeok opened a new issue, #19112:
URL: https://github.com/apache/pulsar/issues/19112

   ### Motivation
   
   Now we have `pulsar_storage_backlog_size` for topic backlog size, user can create an alarm rule like `pulsar_storage_backlog_size > THRESHOLD`, typically this alarm is going to notify corresponding subscription owner, but it need extra process to identify subscriptions that backlog size exceed the threshold. So we could add a new metric for subscription back size.
   
   #9302 Added subscription backlog size info for topic stats and a configuration `exposeSubscriptionBacklogSizeInPrometheus` (default false) for topic metrics, but the latter was unimplemented.
   
   ### Goal
   
   New metric `pulsar_subscription_back_log_size`
   
   ### API Changes
   
   Since `0` is a valid value for subscription backlog size, `change subscriptionStats.backlogSize to -1 from 0` if request the stats of topic with `subscriptionBacklogSize=false`.
   
   ### Implementation
   
   If and only if `exposeSubscriptionBacklogSizeInPrometheus` is enabled, expose the metric as `pulsar_subscription_back_log_size`
   
   ### Alternatives
   
   _No response_
   
   ### Anything else?
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on issue #19112: PIP-235: Add metric for subscription backlog size

[github-actions]

github-actions[bot] commented on issue #19112:
URL: https://github.com/apache/pulsar/issues/19112#issuecomment-1407874775

   The issue had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shawyeok commented on issue #19112: PIP-235: Add metric for subscription back size

[GitBox <gi...@apache.org>]

Shawyeok commented on issue #19112:
URL: https://github.com/apache/pulsar/issues/19112#issuecomment-1367979906

   > How about adding a new label `subscription` in the same metric? It should also not break any existing usage of the metric as well for those only aggregating on `topic` or `cluster` labels
   
   Since it's not enabled by default, it's hard to understanding if it has different meaning after config enabled. It also breaks user existing rule based on the original meaning.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shawyeok commented on issue #19112: PIP-235: Add metric for subscription back size

[GitBox <gi...@apache.org>]

Shawyeok commented on issue #19112:
URL: https://github.com/apache/pulsar/issues/19112#issuecomment-1367983159

   > The author(s) will send a note to the [dev@pulsar.apache.org](mailto:dev@pulsar.apache.org) mailing list to start the discussion, using subject prefix [PIP] xxx. The discussion need to happen in the mailing list. Please avoid discussing it using GitHub comments in the PIP GitHub issue, as it creates two tracks of feedback.
   
   https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md
   
   I've send a discuss to `dev@pulsar.apache.org` mailing list, we may continue discuss on that if you like so.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] grssam commented on issue #19112: PIP-235: Add metric for subscription back size

[GitBox <gi...@apache.org>]

grssam commented on issue #19112:
URL: https://github.com/apache/pulsar/issues/19112#issuecomment-1367973813

   How about adding a new label `subscription` in the same metric? It should also not break any existing usage of the metric as well for those only aggregating on `topic` or `cluster` labels


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] grssam commented on issue #19112: PIP-235: Add metric for subscription back size

[GitBox <gi...@apache.org>]

grssam commented on issue #19112:
URL: https://github.com/apache/pulsar/issues/19112#issuecomment-1367981463

   > Since it's not enabled by default, it's hard to understanding if it has different meaning after config enabled.
   Yes, maybe, but can be fixed with clear documentation.
   
   > It also breaks user existing rule based on the original meaning.
   It adds to the meaning of the existing metric. Any examples on the case where it would break the existing user rule assuming the original meaning?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org