[GitHub] [spark] jiangxb1987 commented on a change in pull request #24618: [SPARK-27734][CORE][SQL] Add memory based thresholds for shuffle spill

[GitBox <gi...@apache.org>]

jiangxb1987 commented on a change in pull request #24618: [SPARK-27734][CORE][SQL] Add memory based thresholds for shuffle spill
URL: https://github.com/apache/spark/pull/24618#discussion_r394796229
 
 

 ##########
 File path: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
 ##########
 @@ -396,8 +407,11 @@ public void insertRecord(
       logger.info("Spilling data because number of spilledRecords crossed the threshold " +
         numElementsForSpillThreshold);
       spill();
+    } else if (inMemRecordsSize >= maxRecordsSizeForSpillThreshold) {
+      logger.info("Spilling data because size of spilledRecords crossed the threshold " +
 
 Review comment:
   Should we also include the number of records and threshold here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org