You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Zhang (JIRA)" <ji...@apache.org> on 2007/01/18 06:13:30 UTC
[jira] Created: (HARMONY-3017) [classlib][sql] Implementation for
SerialClob constructors,getCharacterStream(), and length() methods.
[classlib][sql] Implementation for SerialClob constructors,getCharacterStream(), and length() methods.
------------------------------------------------------------------------------------------------------
Key: HARMONY-3017
URL: https://issues.apache.org/jira/browse/HARMONY-3017
Project: Harmony
Issue Type: New Feature
Components: Classlib
Reporter: Andrew Zhang
Hi,
I'll upload the implementation for SerialClob constructors,getCharacterStream(), and length() methods soon.
Best regards,
Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-3017) [classlib][sql] Implementation for
SerialClob constructors,getCharacterStream(), and length() methods.
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Zhang updated HARMONY-3017:
----------------------------------
Attachment: mf.diff
Hi,
Please ingore the mf part of my first patch. Updated mf.diff fixes the dependency problem as discussed in our mailing list. Thanks!
Best regards,
Andrew
> [classlib][sql] Implementation for SerialClob constructors,getCharacterStream(), and length() methods.
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-3017
> URL: https://issues.apache.org/jira/browse/HARMONY-3017
> Project: Harmony
> Issue Type: New Feature
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Alexei Zakharov
> Attachments: mf.diff, patch.diff
>
>
> Hi,
> I'll upload the implementation for SerialClob constructors,getCharacterStream(), and length() methods soon.
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-3017) [classlib][sql] Implementation for
SerialClob constructors,getCharacterStream(), and length() methods.
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Zakharov closed HARMONY-3017.
------------------------------------
Verified by Andrew.
> [classlib][sql] Implementation for SerialClob constructors,getCharacterStream(), and length() methods.
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-3017
> URL: https://issues.apache.org/jira/browse/HARMONY-3017
> Project: Harmony
> Issue Type: New Feature
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Alexei Zakharov
> Attachments: mf.diff, patch.diff
>
>
> Hi,
> I'll upload the implementation for SerialClob constructors,getCharacterStream(), and length() methods soon.
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3017) [classlib][sql] Implementation for
SerialClob constructors,getCharacterStream(), and length() methods.
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Zhang updated HARMONY-3017:
----------------------------------
Attachment: patch.diff
> [classlib][sql] Implementation for SerialClob constructors,getCharacterStream(), and length() methods.
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-3017
> URL: https://issues.apache.org/jira/browse/HARMONY-3017
> Project: Harmony
> Issue Type: New Feature
> Components: Classlib
> Reporter: Andrew Zhang
> Attachments: patch.diff
>
>
> Hi,
> I'll upload the implementation for SerialClob constructors,getCharacterStream(), and length() methods soon.
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-3017) [classlib][sql] Implementation for
SerialClob constructors,getCharacterStream(), and length() methods.
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469023 ]
Andrew Zhang commented on HARMONY-3017:
---------------------------------------
Hi Alexei,
Thanks! The fix looks fine.
Best regards,
Andrew
> [classlib][sql] Implementation for SerialClob constructors,getCharacterStream(), and length() methods.
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-3017
> URL: https://issues.apache.org/jira/browse/HARMONY-3017
> Project: Harmony
> Issue Type: New Feature
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Alexei Zakharov
> Attachments: mf.diff, patch.diff
>
>
> Hi,
> I'll upload the implementation for SerialClob constructors,getCharacterStream(), and length() methods soon.
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-3017) [classlib][sql] Implementation for
SerialClob constructors,getCharacterStream(), and length() methods.
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Zakharov reassigned HARMONY-3017:
----------------------------------------
Assignee: Alexei Zakharov
> [classlib][sql] Implementation for SerialClob constructors,getCharacterStream(), and length() methods.
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-3017
> URL: https://issues.apache.org/jira/browse/HARMONY-3017
> Project: Harmony
> Issue Type: New Feature
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Alexei Zakharov
> Attachments: patch.diff
>
>
> Hi,
> I'll upload the implementation for SerialClob constructors,getCharacterStream(), and length() methods soon.
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-3017) [classlib][sql] Implementation for
SerialClob constructors,getCharacterStream(), and length() methods.
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467819 ]
Alexei Zakharov commented on HARMONY-3017:
------------------------------------------
Thanks Andrew. Slightly updated version of your original patch as well as the new patch for MANIFEST.MF were applied at the revision 500234. Please verify.
> [classlib][sql] Implementation for SerialClob constructors,getCharacterStream(), and length() methods.
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-3017
> URL: https://issues.apache.org/jira/browse/HARMONY-3017
> Project: Harmony
> Issue Type: New Feature
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Alexei Zakharov
> Attachments: mf.diff, patch.diff
>
>
> Hi,
> I'll upload the implementation for SerialClob constructors,getCharacterStream(), and length() methods soon.
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3017) [classlib][sql] Implementation for
SerialClob constructors,getCharacterStream(), and length() methods.
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466504 ]
Alexei Zakharov commented on HARMONY-3017:
------------------------------------------
BTW, why you've made it dependent on NIO?
> [classlib][sql] Implementation for SerialClob constructors,getCharacterStream(), and length() methods.
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-3017
> URL: https://issues.apache.org/jira/browse/HARMONY-3017
> Project: Harmony
> Issue Type: New Feature
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Alexei Zakharov
> Attachments: patch.diff
>
>
> Hi,
> I'll upload the implementation for SerialClob constructors,getCharacterStream(), and length() methods soon.
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-3017) [classlib][sql] Implementation for
SerialClob constructors,getCharacterStream(), and length() methods.
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466497 ]
Alexei Zakharov commented on HARMONY-3017:
------------------------------------------
Hi Andrew, thanks for the patch, looks good. Just one question, In SerialClob#SerialClob(Clob) you have:
} catch (IOException e) {
throw new SerialException("SerialClob: " + e.getMessage());
}
but I think that it's more useful if we have something like this:
} catch (IOException e) {
SerialException se = new SerialException("SerialClob: " + e.getMessage());
se.initCause(e);
throw se;
}
IMHO this is a standard practice since Java 1.4. Does it make sence?
> [classlib][sql] Implementation for SerialClob constructors,getCharacterStream(), and length() methods.
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-3017
> URL: https://issues.apache.org/jira/browse/HARMONY-3017
> Project: Harmony
> Issue Type: New Feature
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Alexei Zakharov
> Attachments: patch.diff
>
>
> Hi,
> I'll upload the implementation for SerialClob constructors,getCharacterStream(), and length() methods soon.
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-3017) [classlib][sql] Implementation for
SerialClob constructors,getCharacterStream(), and length() methods.
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Zakharov resolved HARMONY-3017.
--------------------------------------
Resolution: Fixed
> [classlib][sql] Implementation for SerialClob constructors,getCharacterStream(), and length() methods.
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-3017
> URL: https://issues.apache.org/jira/browse/HARMONY-3017
> Project: Harmony
> Issue Type: New Feature
> Components: Classlib
> Reporter: Andrew Zhang
> Assigned To: Alexei Zakharov
> Attachments: mf.diff, patch.diff
>
>
> Hi,
> I'll upload the implementation for SerialClob constructors,getCharacterStream(), and length() methods soon.
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3017) [classlib][sql] Implementation for
SerialClob constructors,getCharacterStream(), and length() methods.
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465648 ]
Andrew Zhang commented on HARMONY-3017:
---------------------------------------
Hi,
Would you please try my patch? Thanks!
Best regards,
Andrew
> [classlib][sql] Implementation for SerialClob constructors,getCharacterStream(), and length() methods.
> ------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-3017
> URL: https://issues.apache.org/jira/browse/HARMONY-3017
> Project: Harmony
> Issue Type: New Feature
> Components: Classlib
> Reporter: Andrew Zhang
> Attachments: patch.diff
>
>
> Hi,
> I'll upload the implementation for SerialClob constructors,getCharacterStream(), and length() methods soon.
> Best regards,
> Andrew
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira