You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by dongeforever <gi...@git.apache.org> on 2016/12/26 02:47:08 UTC
[GitHub] incubator-rocketmq pull request #11: [ROCKETMQ-3] Clean up unit tests, remov...
GitHub user dongeforever opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/11
[ROCKETMQ-3] Clean up unit tests, remove try...catch, using assertNull etc
Remove try...catch, using assertNull etc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongeforever/incubator-rocketmq apache_pr
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/11.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11
----
commit ec18e3530b7bc3067dcc7df1c04d3f5fff9244f0
Author: zhendongliu.lzd <zh...@alibaba-inc.com>
Date: 2016-12-26T02:31:45Z
[ROCKETMQ-3] Remove try...catch, using assertNull etc
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #11: [ROCKETMQ-3] Clean up unit tests, remove try.....
Posted by WillemJiang <gi...@git.apache.org>.
Github user WillemJiang commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/11
There is only one line change here after rebasing the codes. I just commit the patch into master branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #11: [ROCKETMQ-3] Clean up unit tests, remov...
Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/11
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #11: [ROCKETMQ-3] Clean up unit tests, remove try.....
Posted by WillemJiang <gi...@git.apache.org>.
Github user WillemJiang commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/11
Please using the mailing list to discuss the code-style issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #11: [ROCKETMQ-3] Clean up unit tests, remove try.....
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/11
@shroman cool, we will add code-style parts in website. Every guys could comment it and help us to perfect it :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #11: [ROCKETMQ-3] Clean up unit tests, remove try.....
Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/11
@WillemJiang I am sorry to bother you so many times. A new pr is created for squashing. And I will take care of my commits carefully next time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #11: [ROCKETMQ-3] Clean up unit tests, remove try.....
Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/11
This PR could be closed for the code has been merged into apache master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---