You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/04/22 04:57:08 UTC
[GitHub] [incubator-inlong] yunqingmoswu opened a new pull request, #3882: [INLONG-3822][Sort] Add node relations definition to support transform
yunqingmoswu opened a new pull request, #3882:
URL: https://github.com/apache/incubator-inlong/pull/3882
### Title Name: [INLONG-3822][Sort] Add node relations definition to support transform
Fixes #3822
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] gong commented on a diff in pull request #3882: [INLONG-3822][Sort] Add node relations definition to support transform
Posted by GitBox <gi...@apache.org>.
gong commented on code in PR #3882:
URL: https://github.com/apache/incubator-inlong/pull/3882#discussion_r856251125
##########
inlong-sort/sort-common/src/test/java/org/apache/inlong/sort/protocol/transformation/relation/InnerJoinNodeRelationTest.java:
##########
@@ -38,10 +38,15 @@
import static org.junit.Assert.assertEquals;
/**
- * Tests for{@link InnerJoinNodeRelationTest}
+ * Tests for {@link InnerJoinNodeRelationTest}
Review Comment:
`InnerJoinNodeRelationTest` should be InnerJoinNodeRelation
##########
inlong-sort/sort-common/src/test/java/org/apache/inlong/sort/protocol/transformation/relation/LeftOuterJoinNodeRelationTest.java:
##########
@@ -38,10 +38,15 @@
import static org.junit.Assert.assertEquals;
/**
- * Tests for{@link LeftOuterJoinNodeRelationTest}
+ * Tests for {@link LeftOuterJoinNodeRelationTest}
Review Comment:
`LeftOuterJoinNodeRelationTest` should be LeftOuterJoinNodeRelation
##########
inlong-sort/sort-common/src/test/java/org/apache/inlong/sort/protocol/transformation/relation/UnionNodeRelationTest.java:
##########
@@ -26,10 +26,15 @@
import static org.junit.Assert.assertEquals;
/**
- * Tests for{@link UnionNodeRelationTest}
+ * Tests for {@link UnionNodeRelationTest}
Review Comment:
`UnionNodeRelationTest` should be UnionNodeRelation
##########
inlong-sort/sort-common/src/test/java/org/apache/inlong/sort/protocol/transformation/relation/NodeRelationTest.java:
##########
@@ -25,10 +25,15 @@
import static org.junit.Assert.assertEquals;
/**
- * Tests for{@link NodeRelationTest}
+ * Tests for {@link NodeRelationTest}
Review Comment:
`NodeRelationTest` should be NodeRelation
##########
inlong-sort/sort-common/src/test/java/org/apache/inlong/sort/protocol/transformation/relation/RightOuterJoinNodeRelationTest.java:
##########
@@ -37,10 +37,15 @@
import static org.junit.Assert.assertEquals;
/**
- * Tests for{@link RightOuterJoinNodeRelationTest}
+ * Tests for {@link RightOuterJoinNodeRelationTest}
Review Comment:
`RightOuterJoinNodeRelationTest` should be RightOuterJoinNodeRelation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] yunqingmoswu commented on a diff in pull request #3882: [INLONG-3822][Sort] Add node relations definition to support transform
Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on code in PR #3882:
URL: https://github.com/apache/incubator-inlong/pull/3882#discussion_r856614476
##########
inlong-sort/sort-common/src/test/java/org/apache/inlong/sort/protocol/transformation/relation/InnerJoinNodeRelationTest.java:
##########
@@ -38,10 +38,15 @@
import static org.junit.Assert.assertEquals;
/**
- * Tests for{@link InnerJoinNodeRelationTest}
+ * Tests for {@link InnerJoinNodeRelationTest}
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] yunqingmoswu commented on a diff in pull request #3882: [INLONG-3822][Sort] Add node relations definition to support transform
Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on code in PR #3882:
URL: https://github.com/apache/incubator-inlong/pull/3882#discussion_r856613654
##########
inlong-sort/sort-common/src/test/java/org/apache/inlong/sort/protocol/transformation/relation/UnionNodeRelationTest.java:
##########
@@ -26,10 +26,15 @@
import static org.junit.Assert.assertEquals;
/**
- * Tests for{@link UnionNodeRelationTest}
+ * Tests for {@link UnionNodeRelationTest}
Review Comment:
done
##########
inlong-sort/sort-common/src/test/java/org/apache/inlong/sort/protocol/transformation/relation/RightOuterJoinNodeRelationTest.java:
##########
@@ -37,10 +37,15 @@
import static org.junit.Assert.assertEquals;
/**
- * Tests for{@link RightOuterJoinNodeRelationTest}
+ * Tests for {@link RightOuterJoinNodeRelationTest}
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #3882: [INLONG-3822][Sort] Add node relations definition to support transform
Posted by GitBox <gi...@apache.org>.
healchow merged PR #3882:
URL: https://github.com/apache/incubator-inlong/pull/3882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] yunqingmoswu commented on a diff in pull request #3882: [INLONG-3822][Sort] Add node relations definition to support transform
Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on code in PR #3882:
URL: https://github.com/apache/incubator-inlong/pull/3882#discussion_r856613776
##########
inlong-sort/sort-common/src/test/java/org/apache/inlong/sort/protocol/transformation/relation/NodeRelationTest.java:
##########
@@ -25,10 +25,15 @@
import static org.junit.Assert.assertEquals;
/**
- * Tests for{@link NodeRelationTest}
+ * Tests for {@link NodeRelationTest}
Review Comment:
done
##########
inlong-sort/sort-common/src/test/java/org/apache/inlong/sort/protocol/transformation/relation/LeftOuterJoinNodeRelationTest.java:
##########
@@ -38,10 +38,15 @@
import static org.junit.Assert.assertEquals;
/**
- * Tests for{@link LeftOuterJoinNodeRelationTest}
+ * Tests for {@link LeftOuterJoinNodeRelationTest}
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org