You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/23 15:16:48 UTC
[GitHub] [shardingsphere] terrymanu opened a new issue #7013: Should use SPI to introduce metrics in SingletonFacadeEngine.buildMetrics which calling on FrontendChannelInboundHandler
terrymanu opened a new issue #7013:
URL: https://github.com/apache/shardingsphere/issues/7013
For ShardingSphere's design way, proxy front module should not understand metrics and other governance concepts.
It is better to use SPI to introduce them.
Please see `FrontendChannelInboundHandler`, line 62
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking commented on issue #7013: Should use SPI to introduce metrics in SingletonFacadeEngine.buildMetrics which calling on FrontendChannelInboundHandler
Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #7013:
URL: https://github.com/apache/shardingsphere/issues/7013#issuecomment-683847819
Since we remove and redesign metrics integrated with java agent [1], now we close this issue.
1. https://github.com/apache/shardingsphere/issues/6653 phase 4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking closed issue #7013: Should use SPI to introduce metrics in SingletonFacadeEngine.buildMetrics which calling on FrontendChannelInboundHandler
Posted by GitBox <gi...@apache.org>.
kimmking closed issue #7013:
URL: https://github.com/apache/shardingsphere/issues/7013
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org