You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/12 20:51:57 UTC
[GitHub] [incubator-tvm] tqchen opened a new pull request #6466: [CMAKE] Improve FindLLVM to handle llvm-prefix with space.
tqchen opened a new pull request #6466:
URL: https://github.com/apache/incubator-tvm/pull/6466
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #6466: [CMAKE] Improve FindLLVM to handle llvm-prefix with space.
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6466:
URL: https://github.com/apache/incubator-tvm/pull/6466
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6466: [CMAKE] Improve FindLLVM to handle llvm-prefix with space.
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6466:
URL: https://github.com/apache/incubator-tvm/pull/6466#issuecomment-691541209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tmoreau89 commented on a change in pull request #6466: [CMAKE] Improve FindLLVM to handle llvm-prefix with space.
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on a change in pull request #6466:
URL: https://github.com/apache/incubator-tvm/pull/6466#discussion_r487446628
##########
File path: python/tvm/contrib/cc.py
##########
@@ -207,66 +204,31 @@ def _linux_compile(output, objects, options, compile_cmd="g++", compile_shared=F
msg += "\nCommand line: " + " ".join(cmd)
raise RuntimeError(msg)
-
def _windows_shared(output, objects, options):
Review comment:
This re-write with clang is a lot cleaner, and aligns with https://github.com/apache/incubator-tvm/blob/master/apps/cpp_rpc/rpc_env.cc#L232-L246 which was tested successfully on windows.
##########
File path: python/tvm/contrib/cc.py
##########
@@ -207,66 +204,31 @@ def _linux_compile(output, objects, options, compile_cmd="g++", compile_shared=F
msg += "\nCommand line: " + " ".join(cmd)
raise RuntimeError(msg)
-
def _windows_shared(output, objects, options):
Review comment:
This re-write with clang is a lot cleaner, and aligns with https://github.com/apache/incubator-tvm/blob/master/apps/cpp_rpc/rpc_env.cc#L232-L246 which was tested successfully on windows.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tmoreau89 commented on a change in pull request #6466: [CMAKE] Improve FindLLVM to handle llvm-prefix with space.
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on a change in pull request #6466:
URL: https://github.com/apache/incubator-tvm/pull/6466#discussion_r487446628
##########
File path: python/tvm/contrib/cc.py
##########
@@ -207,66 +204,31 @@ def _linux_compile(output, objects, options, compile_cmd="g++", compile_shared=F
msg += "\nCommand line: " + " ".join(cmd)
raise RuntimeError(msg)
-
def _windows_shared(output, objects, options):
Review comment:
This re-write with clang is a lot cleaner, and aligns with https://github.com/apache/incubator-tvm/blob/master/apps/cpp_rpc/rpc_env.cc#L232-L246 which was tested successfully on windows.
##########
File path: python/tvm/contrib/cc.py
##########
@@ -207,66 +204,31 @@ def _linux_compile(output, objects, options, compile_cmd="g++", compile_shared=F
msg += "\nCommand line: " + " ".join(cmd)
raise RuntimeError(msg)
-
def _windows_shared(output, objects, options):
Review comment:
This re-write with clang is a lot cleaner, and aligns with https://github.com/apache/incubator-tvm/blob/master/apps/cpp_rpc/rpc_env.cc#L232-L246 which was tested successfully on windows.
##########
File path: python/tvm/contrib/cc.py
##########
@@ -207,66 +204,31 @@ def _linux_compile(output, objects, options, compile_cmd="g++", compile_shared=F
msg += "\nCommand line: " + " ".join(cmd)
raise RuntimeError(msg)
-
def _windows_shared(output, objects, options):
Review comment:
This re-write with clang is a lot cleaner, and aligns with https://github.com/apache/incubator-tvm/blob/master/apps/cpp_rpc/rpc_env.cc#L232-L246 which was tested successfully on windows.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org