You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/16 06:32:26 UTC
[GitHub] [doris] adonis0147 opened a new pull request, #15959: [fix](third-party) Pass search paths of dependencies to CLucene explicitly
adonis0147 opened a new pull request, #15959:
URL: https://github.com/apache/doris/pull/15959
# Proposed changes
~~Issue Number: close #xxx~~
## Problem summary
When building CLucene, CMake may find the wrong Boost and zlib. We should pass the search path to the build command for CLucene explicitly to find the correct dependencies.
```shell
-- old Boost_INCLUDE_DIR :
-- Found Boost: /usr/lib64/boost/BoostConfig.cmake (found version "1.41.0") # Should use the one in thirdparty/installed
Boost found
-- Boost_INCLUDE_DIR : /usr/include
-- Found ZLIB: /devel/ldb_toolchain/usr/lib/libz.so (found version "1.2.11") # Should use the one in thirdparty/installed
```
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [x] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [x] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [x] No Need
4. Does it need to update dependencies:
- [x] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15959: [fix](third-party) Pass search paths of dependencies to CLucene explicitly
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15959:
URL: https://github.com/apache/doris/pull/15959#issuecomment-1383671693
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.07 seconds
load time: 494 seconds
storage size: 17123009456 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230116084003_clickbench_pr_80970.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #15959: [fix](third-party) Pass search paths of dependencies to CLucene explicitly
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #15959:
URL: https://github.com/apache/doris/pull/15959#discussion_r1070900585
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1566,9 +1566,17 @@ build_clucene() {
cd "${BUILD_DIR}"
rm -rf CMakeCache.txt CMakeFiles/
- ${CMAKE_CMD} -G "${GENERATOR}" -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" -DBUILD_STATIC_LIBRARIES=ON \
- -DBUILD_SHARED_LIBRARIES=OFF -DCMAKE_CXX_FLAGS="-fno-omit-frame-pointer ${warning_narrowing}" \
- -DUSE_STAT64=0 -DUSE_AVX2="${USE_AVX2}" -DCMAKE_BUILD_TYPE="${BUILD_TYPE}" -DBUILD_CONTRIBS_LIB=ON ..
+ ${CMAKE_CMD} -G "${GENERATOR}" \
+ -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" \
+ -DBUILD_STATIC_LIBRARIES=ON \
+ -DBUILD_SHARED_LIBRARIES=OFF \
+ -DBOOST_ROOT="${TP_INSTALL_DIR}" \
+ -DZLIB_ROOT="${TP_INSTALL_DIR}" \
Review Comment:
> how about `-DZLIB_LIBRARY="${TP_INSTALL_DIR}/lib/libz.a" -DZLIB_INCLUDE_DIR="${TP_INSTALL_DIR}/include" `
It is sufficient to use just _**one**_ variable `ZLIB_ROOT` to resolve this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] airborne12 commented on a diff in pull request #15959: [fix](third-party) Pass search paths of dependencies to CLucene explicitly
Posted by GitBox <gi...@apache.org>.
airborne12 commented on code in PR #15959:
URL: https://github.com/apache/doris/pull/15959#discussion_r1070897807
##########
thirdparty/build-thirdparty.sh:
##########
@@ -1566,9 +1566,17 @@ build_clucene() {
cd "${BUILD_DIR}"
rm -rf CMakeCache.txt CMakeFiles/
- ${CMAKE_CMD} -G "${GENERATOR}" -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" -DBUILD_STATIC_LIBRARIES=ON \
- -DBUILD_SHARED_LIBRARIES=OFF -DCMAKE_CXX_FLAGS="-fno-omit-frame-pointer ${warning_narrowing}" \
- -DUSE_STAT64=0 -DUSE_AVX2="${USE_AVX2}" -DCMAKE_BUILD_TYPE="${BUILD_TYPE}" -DBUILD_CONTRIBS_LIB=ON ..
+ ${CMAKE_CMD} -G "${GENERATOR}" \
+ -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" \
+ -DBUILD_STATIC_LIBRARIES=ON \
+ -DBUILD_SHARED_LIBRARIES=OFF \
+ -DBOOST_ROOT="${TP_INSTALL_DIR}" \
+ -DZLIB_ROOT="${TP_INSTALL_DIR}" \
Review Comment:
how about
`-DZLIB_LIBRARY="${TP_INSTALL_DIR}/lib/libz.a" -DZLIB_INCLUDE_DIR="${TP_INSTALL_DIR}/include" `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15959: [fix](third-party) Pass search paths of dependencies to CLucene explicitly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15959:
URL: https://github.com/apache/doris/pull/15959#issuecomment-1383691913
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15959: [fix](third-party) Pass search paths of dependencies to CLucene explicitly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15959:
URL: https://github.com/apache/doris/pull/15959#issuecomment-1383691852
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 merged pull request #15959: [fix](third-party) Pass search paths of dependencies to CLucene explicitly
Posted by GitBox <gi...@apache.org>.
adonis0147 merged PR #15959:
URL: https://github.com/apache/doris/pull/15959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org