[GitHub] [solr] risdenk commented on pull request #1367: SOLR-16669: Fix default checkPeerName in Http2SolrClient

["risdenk (via GitHub)" <gi...@apache.org>]

risdenk commented on PR #1367:
URL: https://github.com/apache/solr/pull/1367#issuecomment-1440146823

   Oooo thanks for digging @HoustonPutman agree that 
   
   ```
   sslContextFactory.setEndpointIdentificationAlgorithm(
           System.getProperty("solr.jetty.ssl.verifyClientHostName"));
   ```
   
   looks to be the issue. We should default to `HTTPS` if TLS is not enabled. It looks like we disable client hostname verification by default and the setting `solr.jetty.ssl.verifyClientHostName` only applies if TLS is enabled.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org