You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrea Turli <no...@github.com> on 2013/11/13 17:25:15 UTC
[jclouds-labs] JCLOUDS-336. Move to GCE v1beta16 API. (#36)
I've tested #28 for 1.6.3 and it failed 2 tests:
```
Failed tests: testNetworksAndFirewallDeletedWhenAllGroupNodesAreTerminated(org.jclouds.googlecomputeengine.compute.GoogleComputeEngineServiceExpectTest): expected [GET https://www.googleapis.com/compute/v1beta15/projects/myproject/global/networks/jclouds-test-delete HTTP/1.1(..)
testCreateNodeWhenNetworkNorFirewallExistDoesNotExist(org.jclouds.googlecomputeengine.compute.GoogleComputeEngineServiceExpectTest): expected [GET https://www.googleapis.com/compute/v1beta15/projects/myproject/global/firewalls/jclouds-test-port-22 HTTP/1.1(..)
```
I've opened this new PR that fixes them for [JCLOUDS-226](https://issues.apache.org/jira/browse/JCLOUDS-336)
Hope this helps
You can merge this Pull Request by running:
git pull https://github.com/andreaturli/jclouds-labs fix/JCLOUDS-336
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs/pull/36
-- Commit Summary --
* JCLOUDS-336. Move to GCE v1beta16 API.
-- File Changes --
M google-compute-engine/pom.xml (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/GoogleComputeEngineApi.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/GoogleComputeEngineApiMetadata.java (6)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/config/GoogleComputeEngineParserModule.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/AbstractDisk.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Disk.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Firewall.java (4)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Image.java (4)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Instance.java (10)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Kernel.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/MachineType.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Network.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Operation.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Project.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Zone.java (4)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/DiskApi.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/FirewallApi.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/GlobalOperationApi.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/ImageApi.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/InstanceApi.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/KernelApi.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/MachineTypeApi.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/NetworkApi.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/ProjectApi.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/ZoneApi.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/ZoneOperationApi.java (2)
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/options/ListOptions.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/PageSystemExpectTest.java (8)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineServiceExpectTest.java (38)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/DiskApiExpectTest.java (14)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/FirewallApiExpectTest.java (24)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/GlobalOperationApiExpectTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ImageApiExpectTest.java (12)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/InstanceApiExpectTest.java (28)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/KernelApiExpectTest.java (8)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/MachineTypeApiExpectTest.java (8)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/NetworkApiExpectTest.java (14)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ProjectApiExpectTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ZoneApiExpectTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ZoneOperationApiExpectTest.java (10)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/handlers/GoogleComputeEngineErrorHandlerTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/internal/BaseGoogleComputeEngineApiLiveTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseDiskListTest.java (6)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseDiskTest.java (4)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseFirewallListTest.java (6)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseFirewallTest.java (4)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseImageListTest.java (8)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseImageTest.java (4)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseInstanceListTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseInstanceTest.java (12)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseKernelListTest.java (6)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseKernelTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseMachineTypeListTest.java (8)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseMachineTypeTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseNetworkListTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseNetworkTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseOperationListTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseOperationTest.java (4)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseProjectTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseZoneListTest.java (4)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseZoneTest.java (2)
M google-compute-engine/src/test/resources/GoogleComputeEngineServiceExpectTest/firewall_list.json (8)
M google-compute-engine/src/test/resources/GoogleComputeEngineServiceExpectTest/network_get.json (4)
M google-compute-engine/src/test/resources/disk_get.json (4)
M google-compute-engine/src/test/resources/disk_list.json (6)
M google-compute-engine/src/test/resources/firewall_get.json (4)
M google-compute-engine/src/test/resources/firewall_insert.json (2)
M google-compute-engine/src/test/resources/firewall_list.json (10)
M google-compute-engine/src/test/resources/global_operation.json (4)
M google-compute-engine/src/test/resources/global_operation_list.json (6)
M google-compute-engine/src/test/resources/image_get.json (4)
M google-compute-engine/src/test/resources/image_list.json (8)
M google-compute-engine/src/test/resources/image_list_multiple_page_1.json (18)
M google-compute-engine/src/test/resources/image_list_multiple_page_2.json (14)
M google-compute-engine/src/test/resources/image_list_single_page.json (16)
M google-compute-engine/src/test/resources/instance_add_access_config.json (2)
M google-compute-engine/src/test/resources/instance_get.json (12)
M google-compute-engine/src/test/resources/instance_insert.json (2)
M google-compute-engine/src/test/resources/instance_insert_simple.json (2)
M google-compute-engine/src/test/resources/instance_list.json (14)
M google-compute-engine/src/test/resources/instance_list_central1b_empty.json (2)
M google-compute-engine/src/test/resources/kernel.json (2)
M google-compute-engine/src/test/resources/kernel_list.json (6)
M google-compute-engine/src/test/resources/machinetype.json (2)
M google-compute-engine/src/test/resources/machinetype_list.json (8)
M google-compute-engine/src/test/resources/machinetype_list_central1b.json (6)
M google-compute-engine/src/test/resources/machinetype_list_central1b_empty.json (2)
M google-compute-engine/src/test/resources/network_get.json (2)
M google-compute-engine/src/test/resources/network_list.json (4)
M google-compute-engine/src/test/resources/operation.json (8)
M google-compute-engine/src/test/resources/operation_error.json (8)
M google-compute-engine/src/test/resources/operation_list.json (10)
M google-compute-engine/src/test/resources/project.json (2)
M google-compute-engine/src/test/resources/region_operation.json (6)
M google-compute-engine/src/test/resources/region_operation_list.json (8)
M google-compute-engine/src/test/resources/snapshot_get.json (4)
M google-compute-engine/src/test/resources/zone_get.json (2)
M google-compute-engine/src/test/resources/zone_list.json (6)
M google-compute-engine/src/test/resources/zone_list_short.json (4)
M google-compute-engine/src/test/resources/zone_operation.json (6)
M google-compute-engine/src/test/resources/zone_operation_error.json (6)
M google-compute-engine/src/test/resources/zone_operation_list.json (8)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/36.patch
https://github.com/jclouds/jclouds-labs/pull/36.diff
Re: [jclouds-labs] JCLOUDS-336. Move to GCE v1beta16 API. (#36)
Posted by Andrew Bayer <no...@github.com>.
It's not hugely hard, but it's a real issue and does involve some refactoring - I'm dead certain we'll get 1.7.0 out before they remove the v1beta15 API, and the functional differences between v1beta15 and v1beta16 aren't that sizable, so I think you'll be fine with sticking as is.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/36#issuecomment-28506419
Re: [jclouds-labs] JCLOUDS-336. Move to GCE v1beta16 API. (#36)
Posted by Andrew Bayer <no...@github.com>.
My guess would be that it's tag metadata stuff that's causing issues - I'd advocate just staying on v1beta15 for 1.6.3, given that 1.7.0 (with full support for v1beta16) isn't that far out.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/36#issuecomment-28500776
Re: [jclouds-labs] JCLOUDS-336. Move to GCE v1beta16 API. (#36)
Posted by ahgittin <no...@github.com>.
@andreaturli feels to me it depends how much work is it fixing the tag metadata used for tests. if it's not quick then stick w gce v15 meanwhile roll on jclouds 170 ga !
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/36#issuecomment-28505461
Re: [jclouds-labs] JCLOUDS-336. Move to GCE v1beta16 API. (#36)
Posted by Andrea Turli <no...@github.com>.
let's close this request for now, I'll reopen it as soon as I can get the LiveTests running again.
Thanks @ahgittin and @abayer!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/36#issuecomment-28507953
Re: [jclouds-labs] JCLOUDS-336. Move to GCE v1beta16 API. (#36)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-pull-requests #91](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/91/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/36#issuecomment-28409530
Re: [jclouds-labs] JCLOUDS-336. Move to GCE v1beta16 API. (#36)
Posted by Andrew Bayer <no...@github.com>.
Have you run the live tests?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/36#issuecomment-28451237
Re: [jclouds-labs] JCLOUDS-336. Move to GCE v1beta16 API. (#36)
Posted by Andrea Turli <no...@github.com>.
thanks @abayer
Before closing it, I'd like to have thoughts from @ahgittin and @aledsage. Guys, any comments?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/36#issuecomment-28501328
Re: [jclouds-labs] JCLOUDS-336. Move to GCE v1beta16 API. (#36)
Posted by Andrea Turli <no...@github.com>.
@abayer just now:
```
Failed tests: testInsertDisk(org.jclouds.googlecomputeengine.features.DiskApiLiveTest)
testInsertFirewall(org.jclouds.googlecomputeengine.features.FirewallApiLiveTest)
testInsertInstance(org.jclouds.googlecomputeengine.features.InstanceApiLiveTest)
testInsertNetwork(org.jclouds.googlecomputeengine.features.NetworkApiLiveTest)
Tests run: 57, Failures: 4, Errors: 0, Skipped: 14
```
:(
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/36#issuecomment-28475952