[GitHub] [accumulo] ctubbsii commented on a diff in pull request #2861: Fix additional spotbugs errors in core

[GitBox <gi...@apache.org>]

ctubbsii commented on code in PR #2861:
URL: https://github.com/apache/accumulo/pull/2861#discussion_r943857845


##########
core/src/main/java/org/apache/accumulo/core/metadata/MetadataLocationObtainer.java:
##########
@@ -115,9 +115,9 @@ public TabletLocations lookupTablet(ClientContext context, TabletLocation src, T
         range = new Range(results.lastKey().followingKey(PartialKey.ROW_COLFAM_COLQUAL_COLVIS_TIME),
             true, new Key(stopRow).followingKey(PartialKey.ROW), false);
         encodedResults.clear();
-        more = ThriftScanner.getBatchFromServer(context, range, src.tablet_extent,
-            src.tablet_location, encodedResults, locCols, serverSideIteratorList,
-            serverSideIteratorOptions, Constants.SCAN_BATCH_SIZE, Authorizations.EMPTY, 0L, null);
+        ThriftScanner.getBatchFromServer(context, range, src.tablet_extent, src.tablet_location,
+            encodedResults, locCols, serverSideIteratorList, serverSideIteratorOptions,
+            Constants.SCAN_BATCH_SIZE, Authorizations.EMPTY, 0L, null);

Review Comment:
   This doesn't look correct. Should this `if` loop be a `while` loop instead, so the `more` field is read? What happens if `more` is true here?



##########
core/src/test/java/org/apache/accumulo/fate/util/RetryTest.java:
##########
@@ -81,7 +81,7 @@ public void retriesAreCompleted() {
     for (int i = 0; i < MAX_RETRIES; i++) {
       assertEquals(i, retry.retriesCompleted());
       // canRetry doesn't alter retry's state
-      retry.canRetry();
+      assertTrue(retry.canRetry());

Review Comment:
   Should probably `assertFalse(retry.canRetry())` after the loop.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org