[GitHub] [helix] hmhagberg commented on issue #2024: Are all resources expected to have ResourceConfig?

[GitBox <gi...@apache.org>]

hmhagberg commented on issue #2024:
URL: https://github.com/apache/helix/issues/2024#issuecomment-1092963611

   @narendly thanks for the quick reply! We are not using ConfigAccessor in our application logic. However, I was wrong about the warning coming from `getResourceConfig` -- instead it comes from `get` which is called with scope RESOURCE in HelixTaskExecutor [here](https://github.com/apache/helix/blob/master/helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java#L318).
   
   >the intention is for a given resource to have a ResourceConfig and an IdealState pair
   
   Good info! So the warning is indeed valid and we should be creating ResourceConfig along with IdealState.
   
   Do you think it would make sense to create ResourceConfig by default in `HelixAdmin#addResource`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org