You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/01 04:53:18 UTC

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5395: ui: Allow searching in dropdowns

shwstppr commented on a change in pull request #5395:
URL: https://github.com/apache/cloudstack/pull/5395#discussion_r699842335



##########
File path: ui/src/components/header/SamlDomainSwitcher.vue
##########
@@ -22,6 +22,11 @@
       :loading="loading"
       :defaultValue="currentAccount"
       :value="currentAccount"
+      showSearch
+      optionFilterProp="children"
+      :filterOption="(input, option) => {
+        return option.componentOptions.children[0].text.toLowerCase().indexOf(input.toLowerCase()) >= 0
+      }"

Review comment:
       @davidjumani this code is common across all select items. Is it possible to extract this and have a custom select component?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org