You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/07/08 16:28:47 UTC
[GitHub] [trafficcontrol] shamrickus opened a new pull request #6005: TP: Create AG-Grid Component and Convert DS Server Assignment & Cache Checks
shamrickus opened a new pull request #6005:
URL: https://github.com/apache/trafficcontrol/pull/6005
<!--
************ STOP!! ************
If this Pull Request is intended to fix a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
## What does this PR (Pull Request) do?
<!-- Explain the changes you made here. If this fixes an Issue, identify it by
replacing the text in the checkbox item with the Issue number e.g.
- [x] This PR fixes #9001 OR is not related to any Issue
^ This will automatically close Issue number 9001 when the Pull Request is
merged (The '#' is important).
Be sure you check the box properly, see the "The following criteria are ALL
met by this PR" section for details.
-->
- [x] This PR fixes #5530 <!-- You can check for an issue here: https://github.com/apache/trafficcontrol/issues -->
It also converts two data-tables to ag-grid:
DS Server Assignment
Cache Checks
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this
Pull Request. Also, feel free to add the name of a tool or script that is
affected but not on the list.
Additionally, if this Pull Request does NOT affect documentation, please
explain why documentation is not required. -->
- Traffic Portal
## What is the best way to verify this PR?
Ensure the DS Server Assignment table works (able to assign/unassign servers, already assigned servers are checked, design and flow of new table works).
Ensure the Cache Checks table works (design and flow make sense, revalPending/updPending show a clock/check, the extension columns show either an x or a check, able to drill into the table on click).
Run CiaB off of master, switch to this branch and run TP locally, this makes comparing & contrasting the tables easy.
<!-- Please include here ALL the steps necessary to test your Pull Request. If
it includes tests (and most should), outline here the steps needed to run the
tests. If not, lay out the manual testing procedure and please explain why
tests are unnecessary for this Pull Request. -->
<!-- If this PR fixes a bug, please list here all of the affected versions - to
the best of your knowledge. It's also pretty helpful to include a commit hash
of where 'master' is at the time this PR is opened (if it affects master),
because what 'master' means will change over time. For example, if this PR
fixes a bug that's present in master (at commit hash '1df853c8'), in v4.0.0,
and in the current 4.0.1 Release candidate (e.g. RC1), then this list would
look like:
- master (1df853c8)
- 4.0.0
- 4.0.1 (RC1)
If you don't know what other versions might have this bug, AND don't know how
to find the commit hash of 'master', then feel free to leave this section
blank (or, preferably, delete it entirely).
-->
## The following criteria are ALL met by this PR
<!-- Check the boxes to signify that the associated statement is true. To
"check a box", replace the space inside of the square brackets with an 'x'.
e.g.
- [ x] <- Wrong
- [x ] <- Wrong
- [] <- Wrong
- [*] <- Wrong
- [x] <- Correct!
-->
- [x] This PR includes tests OR I have explained why tests are unnecessary
- [x] This PR includes documentation OR I have explained why documentation is unnecessary
- [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
## Additional Information
There is functionality on the ag-grid component that is not used by the two converted tables, this is because I've done some conversions of other tables (not ready for PR yet) that needed those features.
<!-- If you would like to include any additional information on the PR for
potential reviewers please put it here.
Some examples of this would be:
- Before and after screenshots/gifs of the Traffic Portal if it is affected
- Links to other dependent Pull Requests
- References to relevant context (e.g. new/updates to dependent libraries,
mailing list records, blueprints)
Feel free to leave this section blank (or, preferably, delete it entirely).
-->
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #6005: TP: Create AG-Grid Component and Convert DS Server Assignment & Cache Checks
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #6005:
URL: https://github.com/apache/trafficcontrol/pull/6005#discussion_r666351229
##########
File path: traffic_portal/app/src/common/modules/table/agGrid/CommonGridController.d.ts
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+export namespace CGC {
+ export enum OptionType {
+ Seperator = 0,
+ Button = 1,
+ Ancor = 2
+ }
+
+ export interface GridSettings {
+ rowClassRules?: any;
+ selectRows?: boolean;
+ selectionProperty?: string;
+ refreshable?: boolean;
+
+ onRowClick(row: any): void;
+ }
+
+ export interface CommonOption {
+ type: OptionType;
+ name: string;
+ newTab: boolean;
+
+ onClick(row: any): void;
+ isDisabled(row: any): boolean;
+ shown(row: any): void;
+
+ // If href is undefined, getHref is called
+ href: string;
+ getHref(row: any): string;
+
+ // If text is undefined, getText is called
+ text: string;
Review comment:
According to this typing, `href` and `text` can't be undefined
##########
File path: traffic_portal/app/src/common/modules/table/agGrid/CommonGridController.d.ts
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+export namespace CGC {
+ export enum OptionType {
+ Seperator = 0,
+ Button = 1,
+ Ancor = 2
+ }
+
+ export interface GridSettings {
+ rowClassRules?: any;
Review comment:
I think this is a separate issue from rows being `any` - can this be typed more strictly?
##########
File path: traffic_portal/app/src/common/modules/table/agGrid/CommonGridController.d.ts
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+export namespace CGC {
+ export enum OptionType {
+ Seperator = 0,
+ Button = 1,
+ Ancor = 2
+ }
+
+ export interface GridSettings {
+ rowClassRules?: any;
+ selectRows?: boolean;
+ selectionProperty?: string;
+ refreshable?: boolean;
+
+ onRowClick(row: any): void;
+ }
+
+ export interface CommonOption {
+ type: OptionType;
+ name: string;
+ newTab: boolean;
+
+ onClick(row: any): void;
+ isDisabled(row: any): boolean;
+ shown(row: any): void;
+
+ // If href is undefined, getHref is called
+ href: string;
+ getHref(row: any): string;
+
+ // If text is undefined, getText is called
+ text: string;
+ getText(row: any): string;
+ }
+
+ export interface TitleButton {
+ onClick(): void;
+ getText(): string;
+ }
+
+ export interface DropDownOption extends CommonOption {
+ }
+
+ export interface ContextMenuOption extends CommonOption{
+ }
+
+}
Review comment:
Can we do any better than `any` for the rows passed around in these typings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #6005: TP: Create AG-Grid Component and Convert DS Server Assignment & Cache Checks
Posted by GitBox <gi...@apache.org>.
shamrickus commented on a change in pull request #6005:
URL: https://github.com/apache/trafficcontrol/pull/6005#discussion_r666583739
##########
File path: traffic_portal/app/src/common/modules/table/agGrid/CommonGridController.d.ts
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+export namespace CGC {
+ export enum OptionType {
+ Seperator = 0,
+ Button = 1,
+ Ancor = 2
+ }
+
+ export interface GridSettings {
+ rowClassRules?: any;
+ selectRows?: boolean;
+ selectionProperty?: string;
+ refreshable?: boolean;
+
+ onRowClick(row: any): void;
+ }
+
+ export interface CommonOption {
+ type: OptionType;
+ name: string;
+ newTab: boolean;
+
+ onClick(row: any): void;
+ isDisabled(row: any): boolean;
+ shown(row: any): void;
+
+ // If href is undefined, getHref is called
+ href: string;
+ getHref(row: any): string;
+
+ // If text is undefined, getText is called
+ text: string;
+ getText(row: any): string;
+ }
+
+ export interface TitleButton {
+ onClick(): void;
+ getText(): string;
+ }
+
+ export interface DropDownOption extends CommonOption {
+ }
+
+ export interface ContextMenuOption extends CommonOption{
+ }
+
+}
Review comment:
For the `CommonOption` methods, not really. It's literally the raw row data, which ag-grid also types as `any`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #6005: TP: Create AG-Grid Component and Convert DS Server Assignment & Cache Checks
Posted by GitBox <gi...@apache.org>.
shamrickus commented on a change in pull request #6005:
URL: https://github.com/apache/trafficcontrol/pull/6005#discussion_r669818176
##########
File path: traffic_portal/app/src/common/modules/table/deliveryServiceServers/TableAssignDSServersController.js
##########
@@ -17,87 +17,54 @@
* under the License.
*/
-var TableAssignDSServersController = function(deliveryService, servers, assignedServers, $scope, $uibModalInstance) {
-
- var selectedServers = [];
+/** @typedef { import('../../../../common/modules/table/agGrid/CommonGridController').CGC } CGC */
- var addAll = function() {
- markVisibleServers(true);
- };
-
- var removeAll = function() {
- markVisibleServers(false);
- };
+var TableAssignDSServersController = function(deliveryService, servers, assignedServers, $scope, $uibModalInstance) {
- var markVisibleServers = function(selected) {
- var visibleServerIds = $('#dsServersUnassignedTable tr.server-row').map(
- function() {
- return parseInt($(this).attr('id'));
- }).get();
- $scope.servers = _.map(servers, function(server) {
- if (visibleServerIds.includes(server.id)) {
- server['selected'] = selected;
- }
- return server;
- });
- updateSelectedCount();
- };
+ $scope.selectedServers = [];
- var updateSelectedCount = function() {
- selectedServers = _.filter($scope.servers, function(server) { return server['selected'] == true; } );
- $('div.selected-count').html('<b>' + selectedServers.length + ' servers selected</b>');
- };
+ /** @type CGC.ColumnDefinition */
+ $scope.columns = [
+ {
+ headerName: "Host",
+ field: "hostName",
+ checkboxSelection: true,
+ headerCheckboxSelection: true,
+ },
+ {
+ headerName: "Cache Group",
+ field: "cachegroup",
+ },
+ {
+ headerName: "Profile",
+ field: "profile"
+ }
+ ];
$scope.deliveryService = deliveryService;
- $scope.servers = _.map(servers, function(server) {
- var isAssigned = _.find(assignedServers, function(assignedServer) { return assignedServer.id == server.id });
+ $scope.servers = servers.map(server => {
+ let isAssigned = assignedServers.find(assignedServer => assignedServer.id === server.id);
if (isAssigned) {
server['selected'] = true;
}
return server;
});
- $scope.selectAll = function($event) {
- var checkbox = $event.target;
- if (checkbox.checked) {
- addAll();
- } else {
- removeAll();
- }
- };
-
- $scope.onChange = function() {
- updateSelectedCount();
- };
-
$scope.submit = function() {
- var selectedServerIds = _.pluck(selectedServers, 'id');
+ const selectedServerIds = this.selectedServers.map(s => s["id"]);
Review comment:
/shrug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #6005: TP: Create AG-Grid Component and Convert DS Server Assignment & Cache Checks
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #6005:
URL: https://github.com/apache/trafficcontrol/pull/6005#discussion_r669804036
##########
File path: traffic_portal/app/src/common/modules/table/deliveryServiceServers/TableAssignDSServersController.js
##########
@@ -17,87 +17,54 @@
* under the License.
*/
-var TableAssignDSServersController = function(deliveryService, servers, assignedServers, $scope, $uibModalInstance) {
-
- var selectedServers = [];
+/** @typedef { import('../../../../common/modules/table/agGrid/CommonGridController').CGC } CGC */
- var addAll = function() {
- markVisibleServers(true);
- };
-
- var removeAll = function() {
- markVisibleServers(false);
- };
+var TableAssignDSServersController = function(deliveryService, servers, assignedServers, $scope, $uibModalInstance) {
- var markVisibleServers = function(selected) {
- var visibleServerIds = $('#dsServersUnassignedTable tr.server-row').map(
- function() {
- return parseInt($(this).attr('id'));
- }).get();
- $scope.servers = _.map(servers, function(server) {
- if (visibleServerIds.includes(server.id)) {
- server['selected'] = selected;
- }
- return server;
- });
- updateSelectedCount();
- };
+ $scope.selectedServers = [];
- var updateSelectedCount = function() {
- selectedServers = _.filter($scope.servers, function(server) { return server['selected'] == true; } );
- $('div.selected-count').html('<b>' + selectedServers.length + ' servers selected</b>');
- };
+ /** @type CGC.ColumnDefinition */
+ $scope.columns = [
+ {
+ headerName: "Host",
+ field: "hostName",
+ checkboxSelection: true,
+ headerCheckboxSelection: true,
+ },
+ {
+ headerName: "Cache Group",
+ field: "cachegroup",
+ },
+ {
+ headerName: "Profile",
+ field: "profile"
+ }
+ ];
$scope.deliveryService = deliveryService;
- $scope.servers = _.map(servers, function(server) {
- var isAssigned = _.find(assignedServers, function(assignedServer) { return assignedServer.id == server.id });
+ $scope.servers = servers.map(server => {
+ let isAssigned = assignedServers.find(assignedServer => assignedServer.id === server.id);
if (isAssigned) {
server['selected'] = true;
}
return server;
});
- $scope.selectAll = function($event) {
- var checkbox = $event.target;
- if (checkbox.checked) {
- addAll();
- } else {
- removeAll();
- }
- };
-
- $scope.onChange = function() {
- updateSelectedCount();
- };
-
$scope.submit = function() {
- var selectedServerIds = _.pluck(selectedServers, 'id');
+ const selectedServerIds = this.selectedServers.map(s => s["id"]);
Review comment:
Since when does our build system allow fat-arrow functions? I had to try it myself to believe it worked - that used to break in half.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #6005: TP: Create AG-Grid Component and Convert DS Server Assignment & Cache Checks
Posted by GitBox <gi...@apache.org>.
shamrickus commented on a change in pull request #6005:
URL: https://github.com/apache/trafficcontrol/pull/6005#discussion_r666578358
##########
File path: traffic_portal/app/src/common/modules/table/agGrid/CommonGridController.d.ts
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+export namespace CGC {
+ export enum OptionType {
+ Seperator = 0,
+ Button = 1,
+ Ancor = 2
+ }
+
+ export interface GridSettings {
+ rowClassRules?: any;
+ selectRows?: boolean;
+ selectionProperty?: string;
+ refreshable?: boolean;
+
+ onRowClick(row: any): void;
+ }
+
+ export interface CommonOption {
+ type: OptionType;
+ name: string;
+ newTab: boolean;
+
+ onClick(row: any): void;
+ isDisabled(row: any): boolean;
+ shown(row: any): void;
+
+ // If href is undefined, getHref is called
+ href: string;
+ getHref(row: any): string;
+
+ // If text is undefined, getText is called
+ text: string;
+ getText(row: any): string;
+ }
+
+ export interface TitleButton {
+ onClick(): void;
+ getText(): string;
+ }
+
+ export interface DropDownOption extends CommonOption {
+ }
+
+ export interface ContextMenuOption extends CommonOption{
+ }
+
+}
Review comment:
You are correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #6005: TP: Create AG-Grid Component and Convert DS Server Assignment & Cache Checks
Posted by GitBox <gi...@apache.org>.
shamrickus commented on a change in pull request #6005:
URL: https://github.com/apache/trafficcontrol/pull/6005#discussion_r666531902
##########
File path: traffic_portal/app/src/common/modules/table/agGrid/CommonGridController.d.ts
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+export namespace CGC {
+ export enum OptionType {
+ Seperator = 0,
+ Button = 1,
+ Ancor = 2
+ }
+
+ export interface GridSettings {
+ rowClassRules?: any;
Review comment:
See above comment, this is "shadowing" an ag-grid type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 merged pull request #6005: TP: Create AG-Grid Component and Convert DS Server Assignment & Cache Checks
Posted by GitBox <gi...@apache.org>.
ocket8888 merged pull request #6005:
URL: https://github.com/apache/trafficcontrol/pull/6005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #6005: TP: Create AG-Grid Component and Convert DS Server Assignment & Cache Checks
Posted by GitBox <gi...@apache.org>.
shamrickus commented on a change in pull request #6005:
URL: https://github.com/apache/trafficcontrol/pull/6005#discussion_r666528193
##########
File path: traffic_portal/app/src/common/modules/table/agGrid/CommonGridController.d.ts
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+export namespace CGC {
+ export enum OptionType {
+ Seperator = 0,
+ Button = 1,
+ Ancor = 2
+ }
+
+ export interface GridSettings {
+ rowClassRules?: any;
+ selectRows?: boolean;
+ selectionProperty?: string;
+ refreshable?: boolean;
+
+ onRowClick(row: any): void;
+ }
+
+ export interface CommonOption {
+ type: OptionType;
+ name: string;
+ newTab: boolean;
+
+ onClick(row: any): void;
+ isDisabled(row: any): boolean;
+ shown(row: any): void;
+
+ // If href is undefined, getHref is called
+ href: string;
+ getHref(row: any): string;
+
+ // If text is undefined, getText is called
+ text: string;
+ getText(row: any): string;
+ }
+
+ export interface TitleButton {
+ onClick(): void;
+ getText(): string;
+ }
+
+ export interface DropDownOption extends CommonOption {
+ }
+
+ export interface ContextMenuOption extends CommonOption{
+ }
+
+}
Review comment:
If I add the typings for ag-grid, then a couple of the `any`s could be transformed, I was just trying to avoid installing any typings since this is the only place they're used (and we're transitioning away from this anyways)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #6005: TP: Create AG-Grid Component and Convert DS Server Assignment & Cache Checks
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #6005:
URL: https://github.com/apache/trafficcontrol/pull/6005#discussion_r666537435
##########
File path: traffic_portal/app/src/common/modules/table/agGrid/CommonGridController.d.ts
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+export namespace CGC {
+ export enum OptionType {
+ Seperator = 0,
+ Button = 1,
+ Ancor = 2
+ }
+
+ export interface GridSettings {
+ rowClassRules?: any;
+ selectRows?: boolean;
+ selectionProperty?: string;
+ refreshable?: boolean;
+
+ onRowClick(row: any): void;
+ }
+
+ export interface CommonOption {
+ type: OptionType;
+ name: string;
+ newTab: boolean;
+
+ onClick(row: any): void;
+ isDisabled(row: any): boolean;
+ shown(row: any): void;
+
+ // If href is undefined, getHref is called
+ href: string;
+ getHref(row: any): string;
+
+ // If text is undefined, getText is called
+ text: string;
+ getText(row: any): string;
+ }
+
+ export interface TitleButton {
+ onClick(): void;
+ getText(): string;
+ }
+
+ export interface DropDownOption extends CommonOption {
+ }
+
+ export interface ContextMenuOption extends CommonOption{
+ }
+
+}
Review comment:
Shouldn't you just be able to import the AG-grid typings in this file? They're included in the package, which is already a dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #6005: TP: Create AG-Grid Component and Convert DS Server Assignment & Cache Checks
Posted by GitBox <gi...@apache.org>.
shamrickus commented on a change in pull request #6005:
URL: https://github.com/apache/trafficcontrol/pull/6005#discussion_r666583739
##########
File path: traffic_portal/app/src/common/modules/table/agGrid/CommonGridController.d.ts
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+export namespace CGC {
+ export enum OptionType {
+ Seperator = 0,
+ Button = 1,
+ Ancor = 2
+ }
+
+ export interface GridSettings {
+ rowClassRules?: any;
+ selectRows?: boolean;
+ selectionProperty?: string;
+ refreshable?: boolean;
+
+ onRowClick(row: any): void;
+ }
+
+ export interface CommonOption {
+ type: OptionType;
+ name: string;
+ newTab: boolean;
+
+ onClick(row: any): void;
+ isDisabled(row: any): boolean;
+ shown(row: any): void;
+
+ // If href is undefined, getHref is called
+ href: string;
+ getHref(row: any): string;
+
+ // If text is undefined, getText is called
+ text: string;
+ getText(row: any): string;
+ }
+
+ export interface TitleButton {
+ onClick(): void;
+ getText(): string;
+ }
+
+ export interface DropDownOption extends CommonOption {
+ }
+
+ export interface ContextMenuOption extends CommonOption{
+ }
+
+}
Review comment:
For the `CommonOption` methods, not really. It's literally the raw row data, which ag-grid also types as any.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #6005: TP: Create AG-Grid Component and Convert DS Server Assignment & Cache Checks
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #6005:
URL: https://github.com/apache/trafficcontrol/pull/6005#discussion_r666593717
##########
File path: traffic_portal/app/src/common/modules/table/agGrid/CommonGridController.d.ts
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+export namespace CGC {
+ export enum OptionType {
+ Seperator = 0,
+ Button = 1,
+ Ancor = 2
+ }
+
+ export interface GridSettings {
+ rowClassRules?: any;
+ selectRows?: boolean;
+ selectionProperty?: string;
+ refreshable?: boolean;
+
+ onRowClick(row: any): void;
+ }
+
+ export interface CommonOption {
+ type: OptionType;
+ name: string;
+ newTab: boolean;
+
+ onClick(row: any): void;
+ isDisabled(row: any): boolean;
+ shown(row: any): void;
+
+ // If href is undefined, getHref is called
+ href: string;
+ getHref(row: any): string;
+
+ // If text is undefined, getText is called
+ text: string;
+ getText(row: any): string;
+ }
+
+ export interface TitleButton {
+ onClick(): void;
+ getText(): string;
+ }
+
+ export interface DropDownOption extends CommonOption {
+ }
+
+ export interface ContextMenuOption extends CommonOption{
+ }
+
+}
Review comment:
Well, alright, they'd know I suppose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org