[PATCH] Fix memory leaks in Python bindings

[David James <ja...@cs.toronto.edu>]

Hi Eric,

While reviewing r31055 for merge to the 1.5.x branch, I noticed a few
memory leaks in swigutil_py.c. Some of these memory leaks are new in
r31055 and others have been hanging around in trunk for a while. I
wrote this patch to clean them up.

[[[

Sweep through swigutil_py.c, fixing reference-count memory leaks.

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c

  (make_ob_wc_adm_access): New helper function.

  (svn_swig_py_delta_path_driver_cb_func, ra_callbacks_cancel_func,
   wc_diff_callbacks2_file_changed_or_added, wc_diff_callbacks2_file_deleted,
   wc_diff_callbacks2_dir_added, wc_diff_callbacks2_dir_deleted,
   wc_diff_callbacks2_dir_props_changed): Fix reference-count memory leaks.

]]]

Patch attached as python-memleak-patch.txt.

Cheers,

David

Re: [PATCH] Fix memory leaks in Python bindings

[David James <ja...@cs.toronto.edu>]

On Mon, May 12, 2008 at 3:17 PM, Eric Gillespie <ep...@pretzelnet.org> wrote:
> "David James" <ja...@cs.toronto.edu> writes:
>
>  > While reviewing r31055 for merge to the 1.5.x branch, I noticed a few
>  > memory leaks in swigutil_py.c. Some of these memory leaks are new in
>  > r31055 and others have been hanging around in trunk for a while. I
>  > wrote this patch to clean them up.
>
>  But all were introduced by me :-/.  Looks good, thanks.  After
>  you commit, nominate for 1.5 backport and add a vote from me.

Great! I've committed in r31145 and nominated / voted in r31146.

Thanks,

David

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Fix memory leaks in Python bindings

[Eric Gillespie <ep...@pretzelnet.org>]

"David James" <ja...@cs.toronto.edu> writes:

> While reviewing r31055 for merge to the 1.5.x branch, I noticed a few
> memory leaks in swigutil_py.c. Some of these memory leaks are new in
> r31055 and others have been hanging around in trunk for a while. I
> wrote this patch to clean them up.

But all were introduced by me :-/.  Looks good, thanks.  After
you commit, nominate for 1.5 backport and add a vote from me.

-- 
Eric Gillespie <*> epg@pretzelnet.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org