You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "bmarwell (via GitHub)" <gi...@apache.org> on 2024/08/28 17:57:12 UTC
[PR] [BEANUTILS-565] merge BeanUtilsBean2, ConvertUtilsBean2 up [commons-beanutils]
bmarwell opened a new pull request, #278:
URL: https://github.com/apache/commons-beanutils/pull/278
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BEANUTILS-565] merge BeanUtilsBean2, ConvertUtilsBean2 up [commons-beanutils]
Posted by "bmarwell (via GitHub)" <gi...@apache.org>.
bmarwell commented on PR #278:
URL: https://github.com/apache/commons-beanutils/pull/278#issuecomment-2322941831
@melloware we need to fix those tests first... Input is welcome
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BEANUTILS-565] merge BeanUtilsBean2, ConvertUtilsBean2 up [commons-beanutils]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #278:
URL: https://github.com/apache/commons-beanutils/pull/278#issuecomment-2323000794
Please see the email thread I started on the dev mailing list:
https://lists.apache.org/thread/lg1xs63gjkm0v28nm4d2xsv5vgdq2436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BEANUTILS-565] merge BeanUtilsBean2, ConvertUtilsBean2 up [commons-beanutils]
Posted by "melloware (via GitHub)" <gi...@apache.org>.
melloware commented on PR #278:
URL: https://github.com/apache/commons-beanutils/pull/278#issuecomment-2322950579
OK yes let me look it would almost seem like some Converter was at play that it would expect a date format like that which to me is unexpected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BEANUTILS-565] merge BeanUtilsBean2, ConvertUtilsBean2 up [commons-beanutils]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory closed pull request #278: [BEANUTILS-565] merge BeanUtilsBean2, ConvertUtilsBean2 up
URL: https://github.com/apache/commons-beanutils/pull/278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BEANUTILS-565] merge BeanUtilsBean2, ConvertUtilsBean2 up [commons-beanutils]
Posted by "melloware (via GitHub)" <gi...@apache.org>.
melloware commented on PR #278:
URL: https://github.com/apache/commons-beanutils/pull/278#issuecomment-2322944914
OK this is weird the error is
```
expected:<[28.12.]1992> but was:<[Mon Dec 28 00:00:00 UTC ]1992>
```
But its converting date to toString so I am not sure why it was ever expecting "28.12.1992" ???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BEANUTILS-565] merge BeanUtilsBean2, ConvertUtilsBean2 up [commons-beanutils]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #278:
URL: https://github.com/apache/commons-beanutils/pull/278#issuecomment-2326305582
Hello @bmarwell , @melloware
The pull-up refactoring is now in git master will tests adjusted for the "2" behaviors.
The "2" classes have been removed.
Please pull git master and verify your use cases.
I think this PR can be closed unless I missed something 😉
TY!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BEANUTILS-565] merge BeanUtilsBean2, ConvertUtilsBean2 up [commons-beanutils]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #278:
URL: https://github.com/apache/commons-beanutils/pull/278#issuecomment-2350327810
Closing, no more feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BEANUTILS-565] merge BeanUtilsBean2, ConvertUtilsBean2 up [commons-beanutils]
Posted by "bmarwell (via GitHub)" <gi...@apache.org>.
bmarwell commented on PR #278:
URL: https://github.com/apache/commons-beanutils/pull/278#issuecomment-2322949442
Good question. Does this test depend on some locale? That's a date commonly written like this here in Europe. Merging those two, I might have made an mistake. Also, the new methods delegate to different implementations now, which behave differently.
Without knowing what the previous/original expectations of those methods were, it's really hard to tell.
Will take a look at the docs and Jira issues and git history soon, maybe you can find something out, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BEANUTILS-565] merge BeanUtilsBean2, ConvertUtilsBean2 up [commons-beanutils]
Posted by "melloware (via GitHub)" <gi...@apache.org>.
melloware commented on PR #278:
URL: https://github.com/apache/commons-beanutils/pull/278#issuecomment-2326311017
Yep I think it can be closed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org