You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Vijay (JIRA)" <ji...@apache.org> on 2012/06/08 02:27:22 UTC
[jira] [Created] (CASSANDRA-4320) Assertion error while delivering
the hints.
Vijay created CASSANDRA-4320:
--------------------------------
Summary: Assertion error while delivering the hints.
Key: CASSANDRA-4320
URL: https://issues.apache.org/jira/browse/CASSANDRA-4320
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 1.1.0, 1.2
Reporter: Vijay
Priority: Minor
Fix For: 1.1.2, 1.2
java.lang.AssertionError
at org.apache.cassandra.db.HintedHandOffManager.deliverHintsToEndpointInternal(HintedHandOffManager.java:351)
at org.apache.cassandra.db.HintedHandOffManager.deliverHintsToEndpoint(HintedHandOffManager.java:269)
at org.apache.cassandra.db.HintedHandOffManager.access$400(HintedHandOffManager.java:88)
at org.apache.cassandra.db.HintedHandOffManager$4.runMayThrow(HintedHandOffManager.java:442)
at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:26)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
at java.lang.Thread.run(Thread.java:636)
Did some digging and looks like we just need to skip the deleted columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4320) Assertion error while delivering
the hints.
Posted by "Vijay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-4320:
-----------------------------
Attachment: 0001-CASSANDRA-4320.patch
> Assertion error while delivering the hints.
> -------------------------------------------
>
> Key: CASSANDRA-4320
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4320
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0, 1.2
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.1.2, 1.2
>
> Attachments: 0001-CASSANDRA-4320.patch
>
>
> java.lang.AssertionError
> at org.apache.cassandra.db.HintedHandOffManager.deliverHintsToEndpointInternal(HintedHandOffManager.java:351)
> at org.apache.cassandra.db.HintedHandOffManager.deliverHintsToEndpoint(HintedHandOffManager.java:269)
> at org.apache.cassandra.db.HintedHandOffManager.access$400(HintedHandOffManager.java:88)
> at org.apache.cassandra.db.HintedHandOffManager$4.runMayThrow(HintedHandOffManager.java:442)
> at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:26)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:636)
> Did some digging and looks like we just need to skip the deleted columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4320) Assertion error while
delivering the hints.
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291507#comment-13291507 ]
Jonathan Ellis commented on CASSANDRA-4320:
-------------------------------------------
So... I guess the deletion during one page, doesn't get purged by removeDeleted in the next since it's happening in the same ms?
What if we just increased the gcBefore in the removeDeleted call to MAX_VALUE?
> Assertion error while delivering the hints.
> -------------------------------------------
>
> Key: CASSANDRA-4320
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4320
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0, 1.2
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.1.2, 1.2
>
> Attachments: 0001-CASSANDRA-4320.patch
>
>
> java.lang.AssertionError
> at org.apache.cassandra.db.HintedHandOffManager.deliverHintsToEndpointInternal(HintedHandOffManager.java:351)
> at org.apache.cassandra.db.HintedHandOffManager.deliverHintsToEndpoint(HintedHandOffManager.java:269)
> at org.apache.cassandra.db.HintedHandOffManager.access$400(HintedHandOffManager.java:88)
> at org.apache.cassandra.db.HintedHandOffManager$4.runMayThrow(HintedHandOffManager.java:442)
> at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:26)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:636)
> Did some digging and looks like we just need to skip the deleted columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4320) Assertion error while
delivering the hints.
Posted by "Vijay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291878#comment-13291878 ]
Vijay commented on CASSANDRA-4320:
----------------------------------
Actually v2 wont work because RowMutation.hintFor we do
{code}
ttl = Math.min(ttl, cf.metadata().getGcGraceSeconds());
{code}
so v1 is still better.
> Assertion error while delivering the hints.
> -------------------------------------------
>
> Key: CASSANDRA-4320
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4320
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0, 1.2
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.1.2, 1.2
>
> Attachments: 0001-CASSANDRA-4320-v2.patch, 0001-CASSANDRA-4320.patch
>
>
> java.lang.AssertionError
> at org.apache.cassandra.db.HintedHandOffManager.deliverHintsToEndpointInternal(HintedHandOffManager.java:351)
> at org.apache.cassandra.db.HintedHandOffManager.deliverHintsToEndpoint(HintedHandOffManager.java:269)
> at org.apache.cassandra.db.HintedHandOffManager.access$400(HintedHandOffManager.java:88)
> at org.apache.cassandra.db.HintedHandOffManager$4.runMayThrow(HintedHandOffManager.java:442)
> at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:26)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:636)
> Did some digging and looks like we just need to skip the deleted columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CASSANDRA-4320) Assertion error while delivering
the hints.
Posted by "Vijay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay reassigned CASSANDRA-4320:
--------------------------------
Assignee: Vijay
> Assertion error while delivering the hints.
> -------------------------------------------
>
> Key: CASSANDRA-4320
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4320
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0, 1.2
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.1.2, 1.2
>
>
> java.lang.AssertionError
> at org.apache.cassandra.db.HintedHandOffManager.deliverHintsToEndpointInternal(HintedHandOffManager.java:351)
> at org.apache.cassandra.db.HintedHandOffManager.deliverHintsToEndpoint(HintedHandOffManager.java:269)
> at org.apache.cassandra.db.HintedHandOffManager.access$400(HintedHandOffManager.java:88)
> at org.apache.cassandra.db.HintedHandOffManager$4.runMayThrow(HintedHandOffManager.java:442)
> at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:26)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:636)
> Did some digging and looks like we just need to skip the deleted columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4320) Assertion error while
delivering the hints.
Posted by "Vijay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292391#comment-13292391 ]
Vijay commented on CASSANDRA-4320:
----------------------------------
Sorry i should have been clear, because of
CFS.removeDeletedSuper
{code}
if (subColumn.getLocalDeletionTime() < gcBefore
|| cf.deletionInfo().isDeleted(c.name(), subColumn.timestamp())
|| c.deletionInfo().isDeleted(subColumn))
{
subIter.remove();
}
{code}
Hence we will remove everything and never replay any column if we set the max_value. Makes sense?
> Assertion error while delivering the hints.
> -------------------------------------------
>
> Key: CASSANDRA-4320
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4320
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0, 1.2
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.1.2, 1.2
>
> Attachments: 0001-CASSANDRA-4320-v2.patch, 0001-CASSANDRA-4320.patch
>
>
> java.lang.AssertionError
> at org.apache.cassandra.db.HintedHandOffManager.deliverHintsToEndpointInternal(HintedHandOffManager.java:351)
> at org.apache.cassandra.db.HintedHandOffManager.deliverHintsToEndpoint(HintedHandOffManager.java:269)
> at org.apache.cassandra.db.HintedHandOffManager.access$400(HintedHandOffManager.java:88)
> at org.apache.cassandra.db.HintedHandOffManager$4.runMayThrow(HintedHandOffManager.java:442)
> at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:26)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:636)
> Did some digging and looks like we just need to skip the deleted columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4320) Assertion error while
delivering the hints.
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292363#comment-13292363 ]
Jonathan Ellis commented on CASSANDRA-4320:
-------------------------------------------
I don't follow, using max_value means that if an ExpiringColumn has expired we will ignore it, if it has not then we don't want to.
> Assertion error while delivering the hints.
> -------------------------------------------
>
> Key: CASSANDRA-4320
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4320
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0, 1.2
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.1.2, 1.2
>
> Attachments: 0001-CASSANDRA-4320-v2.patch, 0001-CASSANDRA-4320.patch
>
>
> java.lang.AssertionError
> at org.apache.cassandra.db.HintedHandOffManager.deliverHintsToEndpointInternal(HintedHandOffManager.java:351)
> at org.apache.cassandra.db.HintedHandOffManager.deliverHintsToEndpoint(HintedHandOffManager.java:269)
> at org.apache.cassandra.db.HintedHandOffManager.access$400(HintedHandOffManager.java:88)
> at org.apache.cassandra.db.HintedHandOffManager$4.runMayThrow(HintedHandOffManager.java:442)
> at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:26)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:636)
> Did some digging and looks like we just need to skip the deleted columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4320) Assertion error while delivering
the hints.
Posted by "Vijay (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vijay updated CASSANDRA-4320:
-----------------------------
Attachment: 0001-CASSANDRA-4320-v2.patch
ahaaa that works too :) Plz see the attached. Thanks!
> Assertion error while delivering the hints.
> -------------------------------------------
>
> Key: CASSANDRA-4320
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4320
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0, 1.2
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.1.2, 1.2
>
> Attachments: 0001-CASSANDRA-4320-v2.patch, 0001-CASSANDRA-4320.patch
>
>
> java.lang.AssertionError
> at org.apache.cassandra.db.HintedHandOffManager.deliverHintsToEndpointInternal(HintedHandOffManager.java:351)
> at org.apache.cassandra.db.HintedHandOffManager.deliverHintsToEndpoint(HintedHandOffManager.java:269)
> at org.apache.cassandra.db.HintedHandOffManager.access$400(HintedHandOffManager.java:88)
> at org.apache.cassandra.db.HintedHandOffManager$4.runMayThrow(HintedHandOffManager.java:442)
> at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:26)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:636)
> Did some digging and looks like we just need to skip the deleted columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4320) Assertion error while
delivering the hints.
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294620#comment-13294620 ]
Jonathan Ellis commented on CASSANDRA-4320:
-------------------------------------------
makes sense. committed v1 with a comment.
> Assertion error while delivering the hints.
> -------------------------------------------
>
> Key: CASSANDRA-4320
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4320
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0, 1.2
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.1.2, 1.2
>
> Attachments: 0001-CASSANDRA-4320-v2.patch, 0001-CASSANDRA-4320.patch
>
>
> java.lang.AssertionError
> at org.apache.cassandra.db.HintedHandOffManager.deliverHintsToEndpointInternal(HintedHandOffManager.java:351)
> at org.apache.cassandra.db.HintedHandOffManager.deliverHintsToEndpoint(HintedHandOffManager.java:269)
> at org.apache.cassandra.db.HintedHandOffManager.access$400(HintedHandOffManager.java:88)
> at org.apache.cassandra.db.HintedHandOffManager$4.runMayThrow(HintedHandOffManager.java:442)
> at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:26)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> at java.lang.Thread.run(Thread.java:636)
> Did some digging and looks like we just need to skip the deleted columns.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira