You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/04/10 19:26:18 UTC

[GitHub] [helix] alirezazamani commented on issue #944: Add CustomizedView Root Change Listener to the Router

alirezazamani commented on issue #944: Add CustomizedView Root Change Listener to the Router
URL: https://github.com/apache/helix/pull/944#issuecomment-612182093
 
 
   This PR is ready to be merged, approved by @zhangmeng916 
   
   Final commit message:
   
   Add registration logic for CustomizedView listeners
   
   In this commit, a new logic is added which target the scenario where user
   disables and enables specific types. In this case, since the CustomizedView
   path for that type is removed by the controller, the router looses its
   listener. In this commit, we added root change lister and re-registers the
   listeners again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org