[GitHub] [activemq-artemis] gemmellr commented on issue #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages

[GitBox <gi...@apache.org>]

gemmellr commented on issue #3079: ARTEMIS-2706 Use FrameSize to decide when to flush large messages
URL: https://github.com/apache/activemq-artemis/pull/3079#issuecomment-613669789
 
 
   There isnt a constant, as the encoded size of the transfer performative varies depending on what fields are populated in it, their precise values (since types can vary in size depending on specific value being encoded), etc.
   
   For a different-but-related case, rhea simply deducts 50 bytes and the length of the delivery tag when calculating a max transfer payload size (https://github.com/amqp/rhea/blob/1.0.20/lib/session.js#L137), you could do something similar.
   
   As I noted before, you are just looking at the brokers configured outgoing limit (which is just set the same as its local max frame size). The receivers max frame size may be lower. That mattered with the earlier changes as it could have stopped it flushing, but here the engine will just frame the content however it needs to.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services