You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by sixmen <gi...@git.apache.org> on 2016/10/07 02:54:41 UTC

[GitHub] zeppelin pull request #1494: [ZEPPELIN-451] Save codes and messages as multi...

GitHub user sixmen opened a pull request:

    https://github.com/apache/zeppelin/pull/1494

    [ZEPPELIN-451] Save codes and messages as multi-line

    ### What is this PR for?
    Save Paragraph texts and result msgs as array of strings instead of one long string.
    One long strings are not VCS-friendly.
    
    ### What type of PR is it?
    Improvement
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-451
    
    ### How should this be tested?
    Modify notebooks and check saved note files
    
    ### Screenshots (if appropriate)
    <img width="932" alt="2016-10-07 11 53 28" src="https://cloud.githubusercontent.com/assets/1409279/19177502/bdd40b28-8c84-11e6-8b43-3d6e1318e1c0.png">
    <img width="832" alt="2016-10-07 11 53 44" src="https://cloud.githubusercontent.com/assets/1409279/19177508/c218d768-8c84-11e6-9d4f-ae5227ccb96b.png">
    
    ### Questions:
    * Does the licenses files need update? NO
    * Is there breaking changes for older versions? Notebooks from new zeppelin can not be imported in old zeppelin.
    * Does this needs documentation? NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sixmen/zeppelin note_multiline_string

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1494.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1494
    
----
commit 2a69495d3ef0a97712989dfcf909aecfb2762801
Author: Sangmin Yoon <si...@gmail.com>
Date:   2016-10-05T01:58:40Z

    rename NotebookImportDeserializer to DateDeserializer

commit 2bd5fa9c998c5ad426163ace6e6227f789967342
Author: Sangmin Yoon <si...@gmail.com>
Date:   2016-10-05T08:03:17Z

    save Paragraph.text as list of strings

commit 155a405a5bf93ae1ee8cf34583590e1b24ebaa4c
Author: Sangmin Yoon <si...@gmail.com>
Date:   2016-10-05T08:39:59Z

    save InterpreterResult.msg as list of strings

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1494: [ZEPPELIN-451] Save codes and messages as multi...

Posted by sixmen <gi...@git.apache.org>.
Github user sixmen closed the pull request at:

    https://github.com/apache/zeppelin/pull/1494


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1494: [ZEPPELIN-451] Save codes and messages as multi-line

Posted by sixmen <gi...@git.apache.org>.
Github user sixmen commented on the issue:

    https://github.com/apache/zeppelin/pull/1494
  
    I worked again for this commit with recent sources.
    I hope someone reviews this pull request.
    As I know, there are already breaking changes in the notebook format. So it does not matter with this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1494: [ZEPPELIN-451] Save codes and messages as multi-line

Posted by sixmen <gi...@git.apache.org>.
Github user sixmen commented on the issue:

    https://github.com/apache/zeppelin/pull/1494
  
    It supports old notebook format.
    Old code can not read new notebook format, but it can not be helped any way.
    So I think it is an endurable breaking change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1494: [ZEPPELIN-451] Save codes and messages as multi-line

Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the issue:

    https://github.com/apache/zeppelin/pull/1494
  
    @sixmen thank you for your contribution, this feature looks AWESOME.
    I didnt dive into the code, but one question came in my mind;
    
    This change is kinda *breaking change* since the notebook format is now different from what we have. So what can be the best way in your opinion to support *old* notebook format?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---