You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2018/03/13 22:46:37 UTC
Review Request 66048: Added missing comment on a test case.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66048/
-----------------------------------------------------------
Review request for mesos and Chun-Hung Hsiao.
Repository: mesos
Description
-------
Added missing comment on a test case.
Diffs
-----
src/tests/persistent_volume_tests.cpp 924d8458e54e34a49c99593482b5908c5f7c7a48
Diff: https://reviews.apache.org/r/66048/diff/1/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 66048: Added missing comment on a test case.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66048/#review199141
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66048']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66048
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66048/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (132 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1180 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (37 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (46 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (87 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2526 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2551 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2589 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2614 ms total)
[----------] Global test environment tear-down
[==========] 916 tests from 91 test cases ran. (477778 ms total)
[ PASSED ] 915 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 210 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66048/logs/mesos-tests-stderr.log):
```
I0314 02:23:47.278494 11020 slave.cpp:3878] Shutting down framework b705ee89-009c-4e2c-be5d-176e80a3108f-0000
I0314 02:23:47.278494 2300 master.cpp:10245] Updating the state of task 871495bf-7fec-4a5f-aa4e-949974eecf2c of framework b705ee89-009c-4e2c-be5d-176e80a3108f-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0314 02:23:47.278494 11020 slave.cpp:6571] Shutting down executor '871495bf-7fec-4a5f-aa4e-949974eecf2c' of framework b705ee89-009c-4e2c-be5d-176e80a3108f-0000 at executor(1)@10.3.1.11:62973
I0314 02:23:47.280494 11020 slave.cpp:924] Agent terminating
W0314 02:23:47.280494 11020 slave.cpp:3874] Ignoring shutdown framework b705ee89-009c-4e2c-be5d-176e80a3108f-0000 because it is terminating
I0314 02:23:47.281496 230I0314 02:23:46.550496 8168 exec.cpp:162] Version: 1.6.0
I0314 02:23:46.579524 1228 exec.cpp:236] Executor registered on agent b705ee89-009c-4e2c-be5d-176e80a3108f-S0
I0314 02:23:46.584492 7740 executor.cpp:176] Received SUBSCRIBED event
I0314 02:23:46.589493 7740 executor.cpp:180] Subscribed executor on build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0314 02:23:46.590493 7740 executor.cpp:176] Received LAUNCH event
I0314 02:23:46.595494 7740 executor.cpp:648] Starting task 871495bf-7fec-4a5f-aa4e-949974eecf2c
I0314 02:23:46.680492 7740 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0314 02:23:47.240520 7740 executor.cpp:661] Forked command at 2516
I0314 02:23:47.282495 5872 exec.cpp:445] Executor asked to shutdown
I0314 02:23:47.282495 7740 executor.cpp:176] Received SHUTDOWN event
I0314 02:23:47.283494 7740 executor.cpp:758] Shutting down
I0314 02:23:47.283494 7740 executor.cpp:868] Sending SIGTERM to process tree at pid 20 master.cpp:10344] Removing task 871495bf-7fec-4a5f-aa4e-949974eecf2c with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework b705ee89-009c-4e2c-be5d-176e80a3108f-0000 on agent b705ee89-009c-4e2c-be5d-176e80a3108f-S0 at slave(398)@10.3.1.11:62952 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0314 02:23:47.284492 8272 containerizer.cpp:2338] Destroying container dd72b1a3-477a-4d0d-a687-350c682baf4b in RUNNING state
I0314 02:23:47.284492 8272 containerizer.cpp:2952] Transitioning the state of container dd72b1a3-477a-4d0d-a687-350c682baf4b from RUNNING to DESTROYING
I0314 02:23:47.286497 8272 launcher.cpp:156] Asked to destroy container dd72b1a3-477a-4d0d-a687-350c682baf4b
I0314 02:23:47.286497 2300 master.cpp:1288] Agent b705ee89-009c-4e2c-be5d-176e80a3108f-S0 at slave(398)@10.3.1.11:62952 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0314 02:23:47.286497 2300 master.cpp:3258] Disconnecting agent b705ee89-009c-4e2c-be5d-176e80a3108f-S0 at slave(398)@10.3.1.11:62952 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0314 02:23:47.287492 7324 hierarchical.cpp:344] Removed framework b705ee89-009c-4e2c-be5d-176e80a3108f-0000
I0314 02:23:47.287492 2300 master.cpp:3277] Deactivating agent b705ee89-009c-4e2c-be5d-176e80a3108f-S0 at slave(398)@10.3.1.11:62952 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0314 02:23:47.288492 5376 hierarchical.cpp:766] Agent b705ee89-009c-4e2c-be5d-176e80a3108f-S0 deactivated
I0314 02:23:47.344626 7324 containerizer.cpp:2791] Container dd72b1a3-477a-4d0d-a687-350c682baf4b has exited
I0314 02:23:47.379621 8576 master.cpp:1131] Master terminating
I0314 02:23:47.382613 8512 hierarchical.cpp:609] Removed agent b705ee89-009c-4e2c-be5d-176e80a3108f-S0
I0314 02:23:47.937620 10856 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 13, 2018, 10:46 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66048/
> -----------------------------------------------------------
>
> (Updated March 13, 2018, 10:46 p.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added missing comment on a test case.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp 924d8458e54e34a49c99593482b5908c5f7c7a48
>
>
> Diff: https://reviews.apache.org/r/66048/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 66048: Added missing comment on a test case.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66048/#review199144
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66048]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 13, 2018, 10:46 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66048/
> -----------------------------------------------------------
>
> (Updated March 13, 2018, 10:46 p.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added missing comment on a test case.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp 924d8458e54e34a49c99593482b5908c5f7c7a48
>
>
> Diff: https://reviews.apache.org/r/66048/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 66048: Added missing comment on a test case.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66048/#review205948
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/persistent_volume_tests.cpp
Lines 591-592 (patched)
<https://reviews.apache.org/r/66048/#comment288872>
```
// This test verifies that the agent will provision a persistent volume on a proper path
// when the volume is created by an offer operation.
```
- Chun-Hung Hsiao
On March 13, 2018, 10:46 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66048/
> -----------------------------------------------------------
>
> (Updated March 13, 2018, 10:46 p.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added missing comment on a test case.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp 924d8458e54e34a49c99593482b5908c5f7c7a48
>
>
> Diff: https://reviews.apache.org/r/66048/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>
Re: Review Request 66048: Added missing comment on a test case.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66048/#review205947
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On March 13, 2018, 10:46 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66048/
> -----------------------------------------------------------
>
> (Updated March 13, 2018, 10:46 p.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added missing comment on a test case.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp 924d8458e54e34a49c99593482b5908c5f7c7a48
>
>
> Diff: https://reviews.apache.org/r/66048/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>