You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/30 17:45:41 UTC
[jira] [Commented] (PROTON-1453)
pn_ssl_get_{protocol|cypher}_name() may segfault when called by bindings
[ https://issues.apache.org/jira/browse/PROTON-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949492#comment-15949492 ]
ASF GitHub Bot commented on PROTON-1453:
----------------------------------------
GitHub user kgiusti opened a pull request:
https://github.com/apache/qpid-proton/pull/101
PROTON-1453: properly terminate output string buffer
Fixes the occasional segfault when running travis (as encountered by aconway)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kgiusti/qpid-proton PROTON-1453
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/101.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #101
----
commit e0d2003eca8d536a6a0c25547a51060289f1d7ff
Author: Kenneth Giusti <kg...@apache.org>
Date: 2017-03-30T17:28:57Z
PROTON-1453: properly terminate output string buffer
----
> pn_ssl_get_{protocol|cypher}_name() may segfault when called by bindings
> ------------------------------------------------------------------------
>
> Key: PROTON-1453
> URL: https://issues.apache.org/jira/browse/PROTON-1453
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
> Affects Versions: 0.17.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Fix For: 0.18.0
>
>
> the pn_ssl_get_password/cipher_name method takes a target buffer and length and if the name is known it is copied to the buffer (null terminated) and true is returned.
> However if the name is not known (not yet present) the method returns false and leaves the buffer untouched.
> This is fine for correctly behaving C programs, but the swig generated code always assumes the output buffer contains a properly terminated string whether or not the return value is true. The swigged code unconditionally calls strlen() on the returned buffer.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org