You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "kaijchen (via GitHub)" <gi...@apache.org> on 2023/11/24 11:59:01 UTC
[PR] [fix](move-memtable) handle tablet location not found [doris]
kaijchen opened a new pull request, #27561:
URL: https://github.com/apache/doris/pull/27561
## Proposed changes
Return error if tablet location is nullptr.
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](move-memtable) handle tablet location not found [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27561:
URL: https://github.com/apache/doris/pull/27561#issuecomment-1826354035
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](move-memtable) handle tablet location not found [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27561:
URL: https://github.com/apache/doris/pull/27561#issuecomment-1826354023
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](move-memtable) handle tablet location not found [doris]
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #27561:
URL: https://github.com/apache/doris/pull/27561#issuecomment-1825575640
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](move-memtable) handle tablet location not found [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27561:
URL: https://github.com/apache/doris/pull/27561#issuecomment-1826381660
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit d201b5bd9b4b1c73b288af5c6aaeb381b775ce56, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4914 4691 4655 4655
q2 357 151 159 151
q3 2060 2002 1899 1899
q4 1403 1268 1265 1265
q5 3973 3935 4018 3935
q6 256 135 138 135
q7 1428 880 893 880
q8 2826 2819 2815 2815
q9 9555 9839 9419 9419
q10 3461 3561 3525 3525
q11 385 249 253 249
q12 447 291 306 291
q13 4572 3827 3826 3826
q14 319 284 280 280
q15 583 542 519 519
q16 654 599 587 587
q17 1144 985 945 945
q18 7700 7346 7260 7260
q19 1691 1671 1681 1671
q20 559 316 301 301
q21 4427 4029 3988 3988
q22 483 363 377 363
Total cold run time: 53197 ms
Total hot run time: 48959 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4618 4622 4597 4597
q2 352 262 273 262
q3 4018 4008 3971 3971
q4 2747 2673 2689 2673
q5 9607 9637 9719 9637
q6 248 127 125 125
q7 3025 2465 2441 2441
q8 4469 4457 4451 4451
q9 12899 12887 12809 12809
q10 4066 4173 4164 4164
q11 774 687 745 687
q12 975 807 822 807
q13 4296 3607 3551 3551
q14 382 357 344 344
q15 585 521 540 521
q16 726 672 683 672
q17 3873 3817 3851 3817
q18 9553 9003 8812 8812
q19 1847 1812 1814 1812
q20 2376 2063 2083 2063
q21 8746 8901 8352 8352
q22 882 845 807 807
Total cold run time: 81064 ms
Total hot run time: 77375 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](move-memtable) handle tablet location not found [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #27561:
URL: https://github.com/apache/doris/pull/27561#discussion_r1404282855
##########
be/src/vec/sink/writer/vtablet_writer_v2.cpp:
##########
@@ -274,13 +274,17 @@ Status VTabletWriterV2::_open_streams_to_backend(int64_t dst_id,
return Status::OK();
}
-void VTabletWriterV2::_build_tablet_node_mapping() {
+Status VTabletWriterV2::_build_tablet_node_mapping() {
Review Comment:
warning: method '_build_tablet_node_mapping' can be made static [readability-convert-member-functions-to-static]
be/src/vec/sink/writer/vtablet_writer_v2.h:134:
```diff
- Status _build_tablet_node_mapping();
+ static Status _build_tablet_node_mapping();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](move-memtable) handle tablet location not found [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27561:
URL: https://github.com/apache/doris/pull/27561#issuecomment-1826382791
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.13 seconds
stream load tsv: 568 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 26 seconds loaded 2358488459 Bytes, about 86 MB/s
stream load orc: 71 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17098953558 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](move-memtable) handle tablet location not found [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #27561:
URL: https://github.com/apache/doris/pull/27561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](move-memtable) handle tablet location not found [doris]
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #27561:
URL: https://github.com/apache/doris/pull/27561#issuecomment-1826356806
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](move-memtable) handle tablet location not found [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27561:
URL: https://github.com/apache/doris/pull/27561#issuecomment-1826357132
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org