You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "FMX (via GitHub)" <gi...@apache.org> on 2023/04/17 09:44:34 UTC
[GitHub] [incubator-celeborn] FMX opened a new pull request, #1435: [CELEBORN-526][FLINK] Refine map partition reading thread model.
FMX opened a new pull request, #1435:
URL: https://github.com/apache/incubator-celeborn/pull/1435
### What changes were proposed in this pull request?
Refine the partition reading thread model to reduce contention.
### Why are the changes needed?
Ditto.
### Does this PR introduce _any_ user-facing change?
NO.
### How was this patch tested?
UT and cluster run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1435: [CELEBORN-526][FLINK] Refine map partition reading thread model.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1435:
URL: https://github.com/apache/incubator-celeborn/pull/1435#issuecomment-1511186179
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1435?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1435](https://codecov.io/gh/apache/incubator-celeborn/pull/1435?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9a25931) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/8be82548e1eb502423d305a63021400a8b21c547?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8be8254) will **increase** coverage by `0.26%`.
> The diff coverage is `71.02%`.
```diff
@@ Coverage Diff @@
## main #1435 +/- ##
==========================================
+ Coverage 45.54% 45.79% +0.26%
==========================================
Files 167 168 +1
Lines 10531 10582 +51
Branches 1044 1047 +3
==========================================
+ Hits 4795 4845 +50
Misses 5399 5399
- Partials 337 338 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../common/network/server/MapDataPartitionReader.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9zZXJ2ZXIvTWFwRGF0YVBhcnRpdGlvblJlYWRlci5qYXZh) | `24.46% <60.00%> (+0.46%)` | :arrow_up: |
| [...born/common/network/server/MapPartitionWorker.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9zZXJ2ZXIvTWFwUGFydGl0aW9uV29ya2VyLmphdmE=) | `62.23% <62.23%> (ø)` | |
| [...leborn/common/network/server/MapDataPartition.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9zZXJ2ZXIvTWFwRGF0YVBhcnRpdGlvbi5qYXZh) | `71.32% <85.72%> (+0.68%)` | :arrow_up: |
| [...orn/common/network/server/CreditStreamManager.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9zZXJ2ZXIvQ3JlZGl0U3RyZWFtTWFuYWdlci5qYXZh) | `77.52% <100.00%> (-1.55%)` | :arrow_down: |
| [...cala/org/apache/celeborn/common/CelebornConf.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1435?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL0NlbGVib3JuQ29uZi5zY2FsYQ==) | `86.96% <100.00%> (-0.01%)` | :arrow_down: |
... and [3 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1435/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] github-actions[bot] commented on pull request #1435: [CELEBORN-526][FLINK] Refine map partition reading thread model.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1435:
URL: https://github.com/apache/incubator-celeborn/pull/1435#issuecomment-1554229545
This issue was closed because it has been staled for 10 days with no activity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] github-actions[bot] commented on pull request #1435: [CELEBORN-526][FLINK] Refine map partition reading thread model.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1435:
URL: https://github.com/apache/incubator-celeborn/pull/1435#issuecomment-1537966879
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] github-actions[bot] closed pull request #1435: [CELEBORN-526][FLINK] Refine map partition reading thread model.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #1435: [CELEBORN-526][FLINK] Refine map partition reading thread model.
URL: https://github.com/apache/incubator-celeborn/pull/1435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org