[GitHub] [mina-sshd] tomaswolf commented on a diff in pull request #244: [SSHD-822] Enable more tests for the Netty and MINA I/O back-ends

[GitBox <gi...@apache.org>]

tomaswolf commented on code in PR #244:
URL: https://github.com/apache/mina-sshd/pull/244#discussion_r966757372


##########
sshd-sftp/pom.xml:
##########
@@ -150,7 +150,6 @@
 		            <plugin>
 		                <groupId>org.apache.maven.plugins</groupId>
 		                <artifactId>maven-surefire-plugin</artifactId>
-                        <version>${surefire.plugin.version}</version>

Review Comment:
   The maven-surefire-plugin version is pinned to ${surefire.plugin.version} in the parent <pluginManagement> of the parent pom. It is therefore unnecessary and in fact bad practice to define it again here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org