You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Anthony Abate (JIRA)" <ji...@apache.org> on 2008/11/13 17:42:44 UTC
[jira] Created: (THRIFT-204) C# Partial Classes
C# Partial Classes
------------------
Key: THRIFT-204
URL: https://issues.apache.org/jira/browse/THRIFT-204
Project: Thrift
Issue Type: Improvement
Components: Compiler (C#)
Environment: all
Reporter: Anthony Abate
Priority: Critical
Generated classes should be "partial"
most code generated from Microsoft code generation tools these days is "partial". This way a developer can easily extend the class.
If i found the correct line in the t_csharp_generator.cc , then his is a very easy fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-204) C# Partial Classes
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury resolved THRIFT-204.
----------------------------------
Resolution: Fixed
Fix Version/s: 0.2
Assignee: Michael Greene
I just committed this. Thanks for the patch, Michael!
> C# Partial Classes
> ------------------
>
> Key: THRIFT-204
> URL: https://issues.apache.org/jira/browse/THRIFT-204
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (C#)
> Environment: all
> Reporter: Anthony Abate
> Assignee: Michael Greene
> Priority: Minor
> Fix For: 0.2
>
> Attachments: partial classes.patch, thrift-204_partial_classes_v2.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Generated classes should be "partial"
> most code generated from Microsoft code generation tools these days is "partial". This way a developer can easily extend the class.
> If i found the correct line in the t_csharp_generator.cc , then his is a very easy fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-204) C# Partial Classes
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-204:
-------------------------------
Priority: Minor (was: Critical)
> C# Partial Classes
> ------------------
>
> Key: THRIFT-204
> URL: https://issues.apache.org/jira/browse/THRIFT-204
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (C#)
> Environment: all
> Reporter: Anthony Abate
> Priority: Minor
> Attachments: partial classes.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Generated classes should be "partial"
> most code generated from Microsoft code generation tools these days is "partial". This way a developer can easily extend the class.
> If i found the correct line in the t_csharp_generator.cc , then his is a very easy fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-204) C# Partial Classes
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated THRIFT-204:
----------------------------------
Attachment: thrift-204_partial_classes_v2.patch
Needed to be rebased to trunk following the new final modifier. I am recommending this patch for commit, as I have started using it locally.
> C# Partial Classes
> ------------------
>
> Key: THRIFT-204
> URL: https://issues.apache.org/jira/browse/THRIFT-204
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (C#)
> Environment: all
> Reporter: Anthony Abate
> Priority: Minor
> Attachments: partial classes.patch, thrift-204_partial_classes_v2.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Generated classes should be "partial"
> most code generated from Microsoft code generation tools these days is "partial". This way a developer can easily extend the class.
> If i found the correct line in the t_csharp_generator.cc , then his is a very easy fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-204) C# Partial Classes
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647338#action_12647338 ]
Michael Greene commented on THRIFT-204:
---------------------------------------
I don't have any immediate objects, but I haven't tested this out yet.
I'd actually be in favor of making all classes {{sealed}} and {{partial}}, but I haven't looked deep into the ramifications of this either. Thoughts?
I'll take a look at some of your other issues as well.
> C# Partial Classes
> ------------------
>
> Key: THRIFT-204
> URL: https://issues.apache.org/jira/browse/THRIFT-204
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (C#)
> Environment: all
> Reporter: Anthony Abate
> Priority: Critical
> Attachments: partial classes.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Generated classes should be "partial"
> most code generated from Microsoft code generation tools these days is "partial". This way a developer can easily extend the class.
> If i found the correct line in the t_csharp_generator.cc , then his is a very easy fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-204) C# Partial Classes
Posted by "Anthony Abate (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647336#action_12647336 ]
Anthony Abate commented on THRIFT-204:
--------------------------------------
I think it safe to change all 'public class' to 'public partial class'
any objections?
> C# Partial Classes
> ------------------
>
> Key: THRIFT-204
> URL: https://issues.apache.org/jira/browse/THRIFT-204
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (C#)
> Environment: all
> Reporter: Anthony Abate
> Priority: Critical
> Attachments: partial classes.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Generated classes should be "partial"
> most code generated from Microsoft code generation tools these days is "partial". This way a developer can easily extend the class.
> If i found the correct line in the t_csharp_generator.cc , then his is a very easy fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-204) C# Partial Classes
Posted by "Anthony Abate (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anthony Abate updated THRIFT-204:
---------------------------------
Attachment: partial classes.patch
untested, but I think this is the correct line to change
> C# Partial Classes
> ------------------
>
> Key: THRIFT-204
> URL: https://issues.apache.org/jira/browse/THRIFT-204
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (C#)
> Environment: all
> Reporter: Anthony Abate
> Priority: Critical
> Attachments: partial classes.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Generated classes should be "partial"
> most code generated from Microsoft code generation tools these days is "partial". This way a developer can easily extend the class.
> If i found the correct line in the t_csharp_generator.cc , then his is a very easy fix.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.