[GitHub] [doris] DongLiang-0 commented on a diff in pull request #19990: [Feature](avro) Support Apache Avro file format

["DongLiang-0 (via GitHub)" <gi...@apache.org>]

DongLiang-0 commented on code in PR #19990:
URL: https://github.com/apache/doris/pull/19990#discussion_r1232125659


##########
be/src/vec/exec/jni_connector.h:
##########
@@ -165,9 +165,28 @@ class JniConnector {
               _scanner_params(std::move(scanner_params)),
               _column_names(std::move(column_names)) {}
 
+    /**
+    * Use configuration map to provide scan information. The java side should determine how the parameters are parsed.
+    * @param connector_class Java scanner class
+    * @param scanner_params Provided configuration map
+    */
+    JniConnector(std::string connector_class, std::map<std::string, std::string> scanner_params)
+            : _connector_class(std::move(connector_class)),
+              _scanner_params(std::move(scanner_params)) {
+        _is_table_schema = true;

Review Comment:
   Java memory is used here, not direct memory, which is managed by JVM



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org