You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Romain Manni-Bucau <rm...@gmail.com> on 2018/01/19 10:47:28 UTC
anyone fixing the build?
Hi guys,
Recent merges broke the build / tests it seems.
I also saw some weird code like
https://github.com/apache/tomee/blob/master/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java#L2562
which is doing twice the "same thing" so sounds like we have 2 ways to
deploy an app container now
(org.apache.openejb.config.AppInfoBuilder#buildAppResources was probably
intended to be dropped).
Can someone with the knowledge at least check the build and if the issue is
too nasty revert the related code to ensure we are back to green on master
at least - if ambiguous, it is fine for me to be red if somebody works on
fixing it, it is not if we stay like that ;)?
Thanks,
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau>
Re: anyone fixing the build?
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Thanks Jon!
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau>
2018-01-19 12:47 GMT+01:00 Jonathan Gallimore <jo...@gmail.com>
:
> Ok, the mix up with container there is my mistake, and I'll fix it as soon
> as I can. I'll sort out the test failures as well. Thanks for the nudge.
>
> Jon
>
> On Fri, Jan 19, 2018 at 11:39 AM, Jonathan Gallimore <
> jonathan.gallimore@gmail.com> wrote:
>
> > I'll take a look.
> >
> > Thanks
> >
> > Jon
> >
> > On 19 Jan 2018 10:47, "Romain Manni-Bucau" <rm...@gmail.com>
> wrote:
> >
> >> Hi guys,
> >>
> >> Recent merges broke the build / tests it seems.
> >> I also saw some weird code like
> >> https://github.com/apache/tomee/blob/master/container/openej
> >> b-core/src/main/java/org/apache/openejb/assembler/class
> >> ic/Assembler.java#L2562
> >> which is doing twice the "same thing" so sounds like we have 2 ways to
> >> deploy an app container now
> >> (org.apache.openejb.config.AppInfoBuilder#buildAppResources was
> probably
> >> intended to be dropped).
> >>
> >> Can someone with the knowledge at least check the build and if the issue
> >> is
> >> too nasty revert the related code to ensure we are back to green on
> master
> >> at least - if ambiguous, it is fine for me to be red if somebody works
> on
> >> fixing it, it is not if we stay like that ;)?
> >>
> >> Thanks,
> >> Romain Manni-Bucau
> >> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> >> <https://rmannibucau.metawerx.net/> | Old Blog
> >> <http://rmannibucau.wordpress.com> | Github <
> >> https://github.com/rmannibucau> |
> >> LinkedIn <https://www.linkedin.com/in/rmannibucau>
> >>
> >
>
Re: anyone fixing the build?
Posted by Jonathan Gallimore <jo...@gmail.com>.
Ok, the mix up with container there is my mistake, and I'll fix it as soon
as I can. I'll sort out the test failures as well. Thanks for the nudge.
Jon
On Fri, Jan 19, 2018 at 11:39 AM, Jonathan Gallimore <
jonathan.gallimore@gmail.com> wrote:
> I'll take a look.
>
> Thanks
>
> Jon
>
> On 19 Jan 2018 10:47, "Romain Manni-Bucau" <rm...@gmail.com> wrote:
>
>> Hi guys,
>>
>> Recent merges broke the build / tests it seems.
>> I also saw some weird code like
>> https://github.com/apache/tomee/blob/master/container/openej
>> b-core/src/main/java/org/apache/openejb/assembler/class
>> ic/Assembler.java#L2562
>> which is doing twice the "same thing" so sounds like we have 2 ways to
>> deploy an app container now
>> (org.apache.openejb.config.AppInfoBuilder#buildAppResources was probably
>> intended to be dropped).
>>
>> Can someone with the knowledge at least check the build and if the issue
>> is
>> too nasty revert the related code to ensure we are back to green on master
>> at least - if ambiguous, it is fine for me to be red if somebody works on
>> fixing it, it is not if we stay like that ;)?
>>
>> Thanks,
>> Romain Manni-Bucau
>> @rmannibucau <https://twitter.com/rmannibucau> | Blog
>> <https://rmannibucau.metawerx.net/> | Old Blog
>> <http://rmannibucau.wordpress.com> | Github <
>> https://github.com/rmannibucau> |
>> LinkedIn <https://www.linkedin.com/in/rmannibucau>
>>
>
Re: anyone fixing the build?
Posted by Jonathan Gallimore <jo...@gmail.com>.
I'll take a look.
Thanks
Jon
On 19 Jan 2018 10:47, "Romain Manni-Bucau" <rm...@gmail.com> wrote:
> Hi guys,
>
> Recent merges broke the build / tests it seems.
> I also saw some weird code like
> https://github.com/apache/tomee/blob/master/container/
> openejb-core/src/main/java/org/apache/openejb/assembler/
> classic/Assembler.java#L2562
> which is doing twice the "same thing" so sounds like we have 2 ways to
> deploy an app container now
> (org.apache.openejb.config.AppInfoBuilder#buildAppResources was probably
> intended to be dropped).
>
> Can someone with the knowledge at least check the build and if the issue is
> too nasty revert the related code to ensure we are back to green on master
> at least - if ambiguous, it is fine for me to be red if somebody works on
> fixing it, it is not if we stay like that ;)?
>
> Thanks,
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <https://github.com/
> rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau>
>